Closed Bug 1318808 Opened 8 years ago Closed 8 years ago

diff settings different for reviewboard-hg repository relative to other repositories (3 rather than 8 lines of context, showfunc)

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dbaron, Unassigned)

Details

Repositories on hg.mozilla.org are configured to produce diffs with 8 lines of context, as is Mozilla convention.

However, reviewboard-hg.mozilla.org doesn't seem to have this configuration, and shows 3 lines of context.

This means that if I want to review the diffs for a patch that I've already reviewed (which MozReview makes hard enough), it's hard to diff the patches by diffing:
https://hg.mozilla.org/mozilla-central/raw-rev/d1d614497fbf
against
https://reviewboard-hg.mozilla.org/gecko/raw-rev/c31568af155e6dd050010bf909ba913b2b7f82dc


It's also not using "showfunc" (or, for diff, -p).
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/4b97d220a25d
ansible/hg-reviewboard: show 8 lines of context in diffs
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.