1318848 - results left offset doesn't take <toolbaritem> nodes into account

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect, P3)

Description

[plaetaggou]

Attachment: search results alignment for <toolbaritem> vs <toolbarbutton>

a couple releases ago, the location bar search results dropdown was changed, and now it expands horizontally to fill the width of the screen. the results listed inside have a left offset determined by the sum of widths of items placed to the left of the location bar -- this allows the results text to line up with the location bar text ...

but the left offset doesn't take into account <toolbaritem> nodes. in troubleshooting, simply changing a <toolbaritem> to <toolbarbutton> using inspector allowed the location bar to correctly offset the search results. please reference attached image which illustrates the problem, as well as how it's supposed to align.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Right, by default we considered users putting toolbarbuttons there, we don't have a lot of toolbaritems in the palette. But we could likely support them

http://searchfox.org/mozilla-central/rev/935627b015aaabbd2dffa90cce051521f22dd7e6/browser/base/content/urlbarBindings.xml#1618

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

This is now outdated