results left offset doesn't take <toolbaritem> nodes into account

NEW
Unassigned

Status

()

defect
P3
normal
3 years ago
3 years ago

People

(Reporter: plaetaggou, Unassigned)

Tracking

50 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

a couple releases ago, the location bar search results dropdown was changed, and now it expands horizontally to fill the width of the screen. the results listed inside have a left offset determined by the sum of widths of items placed to the left of the location bar -- this allows the results text to line up with the location bar text ...

but the left offset doesn't take into account <toolbaritem> nodes. in troubleshooting, simply changing a <toolbaritem> to <toolbarbutton> using inspector allowed the location bar to correctly offset the search results. please reference attached image which illustrates the problem, as well as how it's supposed to align.
Right, by default we considered users putting toolbarbuttons there, we don't have a lot of toolbaritems in the palette. But we could likely support them

http://searchfox.org/mozilla-central/rev/935627b015aaabbd2dffa90cce051521f22dd7e6/browser/base/content/urlbarBindings.xml#1618
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Whiteboard: [fxsearch]
You need to log in before you can comment on or make changes to this bug.