Closed Bug 1318867 Opened 8 years ago Closed 8 years ago

Intermittent browser_grouped_session_store.js | Index matches - Got 2, expected 1 | Index matches - Got 4, expected 3

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: aryx, Assigned: nika)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Listen for a LocationChange event after changing processes before flushing SessionStore
2.21 KB, patch
mikedeboer
: review+
Details | Diff | Splinter Review 
[task 2016-11-19T14:16:46.357642Z] 14:16:46     INFO - TEST-PASS | browser/components/sessionstore/test/browser_grouped_session_store.js | Lengths match - 
[task 2016-11-19T14:16:46.359716Z] 14:16:46     INFO - TEST-PASS | browser/components/sessionstore/test/browser_grouped_session_store.js | URI at index 0 matches - 
[task 2016-11-19T14:16:46.362002Z] 14:16:46     INFO - TEST-PASS | browser/components/sessionstore/test/browser_grouped_session_store.js | URI at index 1 matches - 
[task 2016-11-19T14:16:46.364485Z] 14:16:46     INFO - TEST-PASS | browser/components/sessionstore/test/browser_grouped_session_store.js | URI at index 2 matches - 
[task 2016-11-19T14:16:46.369494Z] 14:16:46     INFO - TEST-PASS | browser/components/sessionstore/test/browser_grouped_session_store.js | URI at index 3 matches - 
[task 2016-11-19T14:16:46.371185Z] 14:16:46     INFO - Buffered messages finished
[task 2016-11-19T14:16:46.373854Z] 14:16:46     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_grouped_session_store.js | Index matches - Got 2, expected 1
[task 2016-11-19T14:16:46.375404Z] 14:16:46     INFO - Stack trace:
[task 2016-11-19T14:16:46.378386Z] 14:16:46     INFO -     chrome://mochikit/content/browser-test.js:test_is:913
[task 2016-11-19T14:16:46.380235Z] 14:16:46     INFO -     chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_grouped_session_store.js:validate:25
[task 2016-11-19T14:16:46.382182Z] 14:16:46     INFO -     chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_grouped_session_store.js:null:92
[task 2016-11-19T14:16:46.384315Z] 14:16:46     INFO -     @chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_grouped_session_store.js:49:9
[task 2016-11-19T14:16:46.390299Z] 14:16:46     INFO -     TaskImpl_run@resource://gre/modules/Task.jsm:319:42
[task 2016-11-19T14:16:46.392393Z] 14:16:46     INFO -     promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:396:7
[task 2016-11-19T14:16:46.397342Z] 14:16:46     INFO -     TaskImpl_run@resource://gre/modules/Task.jsm:327:15
[task 2016-11-19T14:16:46.399125Z] 14:16:46     INFO -     TaskImpl@resource://gre/modules/Task.jsm:277:3
[task 2016-11-19T14:16:46.401071Z] 14:16:46     INFO -     createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:252:14
[task 2016-11-19T14:16:46.404661Z] 14:16:46     INFO -     Task_spawn@resource://gre/modules/Task.jsm:166:12
[task 2016-11-19T14:16:46.406317Z] 14:16:46     INFO -     TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:389:16
[task 2016-11-19T14:16:46.407963Z] 14:16:46     INFO -     TaskImpl_run@resource://gre/modules/Task.jsm:327:15
[task 2016-11-19T14:16:46.409812Z] 14:16:46     INFO -     TaskImpl@resource://gre/modules/Task.jsm:277:3
[task 2016-11-19T14:16:46.411690Z] 14:16:46     INFO -     createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:252:14
[task 2016-11-19T14:16:46.413560Z] 14:16:46     INFO -     Task_spawn@resource://gre/modules/Task.jsm:166:12
[task 2016-11-19T14:16:46.417750Z] 14:16:46     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:737:9
[task 2016-11-19T14:16:46.420441Z] 14:16:46     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:657:7
[task 2016-11-19T14:16:46.423056Z] 14:16:46     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:744:59
[task 2016-11-19T14:16:46.425
This test was just added in bug 1310771, https://hg.mozilla.org/integration/mozilla-inbound/rev/5fa643642a67.
Flags: needinfo?(michael)
This patch makes us wait for the locationchange event to be fired, which from my testing with rr chaos mode eliminates the intermittents. This makes sense as the intermittents seem to be occuring when navigating during swapping, which happens asynchronously after the BrowserChangedProcess event would be fired.

MozReview-Commit-ID: GidwIVWEy2s
Attachment #8813874 - Flags: review?(mdeboer)
Assignee: nobody → michael
Flags: needinfo?(michael)
Attachment #8813874 - Flags: review?(mdeboer) → review+
I'd really to sit down with you some time to learn more about rr chaos mode. I think it'll be helpful for me to solve many more intermittents more efficiently!
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e372790cc35
Listen for a LocationChange event after changing processes before flushing SessionStore, r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/2e372790cc35
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: