1318971 - Type mismatch in ContentParent::RecvPSpeechSynthesisConstructor when MOZ_WEBSPEECH is not defined

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Tooru Fujisawa [:arai]]

http://searchfox.org/mozilla-central/rev/935627b015aaabbd2dffa90cce051521f22dd7e6/dom/ipc/ContentParent.cpp#3125-3127
> mozilla::ipc::IPCResult
> ContentParent::RecvPSpeechSynthesisConstructor(PSpeechSynthesisParent* aActor)
> {
> #ifdef MOZ_WEBSPEECH
>   return IPC_OK();
> #else
>   return false;
> #endif
> }

the #else part should be updated to |IPC_FAIL_NO_REASON(this);| or something.

Comment 1

[:aceman]

mozilla/dom/ipc/ContentParent.cpp:3147:10: error: could not convert ‘false’ from ‘bool’ to ‘mozilla::ipc::IPCResult’
with gcc 5 on linux, when --disable-webspeech set in mozconfig

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Update !MOZ_WEBSPEECH case in ContentParent::RecvPSpeechSynthesisConstructor to return mozilla::ipc::IPCResult.

Just replaced false with |IPC_FAIL_NO_REASON(this)|, that seems to be the value for error case.

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/578dfd6dba5e20d87b7642acef8d093d8be8e268
Bug 1318971 - Update !MOZ_WEBSPEECH case in ContentParent::RecvPSpeechSynthesisConstructor to return mozilla::ipc::IPCResult. r=kanru

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/578dfd6dba5e