1318982 - Enable dormant for most media mochitests

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

There are some test failures with dormant enabled:

test_Eviction_mp4.html
test_PlayEvents.html
test_ResumeAfterClearing_mp4.html

We will fix them in follow-up bugs.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1318982 - Enable dormant for most media mochitests.

Review commit: https://reviewboard.mozilla.org/r/94288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94288/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8812641 [details]
Bug 1318982 - Enable dormant for most media mochitests.

https://reviewboard.mozilla.org/r/94288/#review94778

::: dom/media/mediasource/test/test_Eviction_mp4.html:36
(Diff revision 1)
>    });
>  }
>  
> +addMSEPrefs(
> +  ["media.mediasource.eviction_threshold.audio", 524288],
> +  ["media.dormant-on-pause-timeout-ms", -1] // Disable dormant.

not aligned... extra space line 35

::: dom/media/mediasource/test/test_Eviction_mp4.html:36
(Diff revision 1)
>    });
>  }
>  
> +addMSEPrefs(
> +  ["media.mediasource.eviction_threshold.audio", 524288],
> +  ["media.dormant-on-pause-timeout-ms", -1] // Disable dormant.

Could you please add a comment describing for each test where dormant is disabled, on why it's disabled with a bug created for each of those?

I don't see why dormant should be disabled here, seeing that dormant should be invisible to JS anyway

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8812641 [details]
Bug 1318982 - Enable dormant for most media mochitests.

https://reviewboard.mozilla.org/r/94288/#review94778

> not aligned... extra space line 35

Can you point me at the space? I can't find it.

> Could you please add a comment describing for each test where dormant is disabled, on why it's disabled with a bug created for each of those?
> 
> I don't see why dormant should be disabled here, seeing that dormant should be invisible to JS anyway

Still figuring out why dormant causes test failures. I will file follow-up bugs.

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8812641 [details]
Bug 1318982 - Enable dormant for most media mochitests.

https://reviewboard.mozilla.org/r/94288/#review94778

> Can you point me at the space? I can't find it.

doh, I don't see it anymore..

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8812641 [details]
Bug 1318982 - Enable dormant for most media mochitests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94288/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af9ac4bc7efd
Enable dormant for most media mochitests. r=jya

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af9ac4bc7efd