Enable dormant for most media mochitests

RESOLVED FIXED in Firefox 53

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
There are some test failures with dormant enabled:

test_Eviction_mp4.html
test_PlayEvents.html
test_ResumeAfterClearing_mp4.html

We will fix them in follow-up bugs.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Blocks: 1286129
Priority: -- → P3
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8812641 [details]
Bug 1318982 - Enable dormant for most media mochitests.

https://reviewboard.mozilla.org/r/94288/#review94778

::: dom/media/mediasource/test/test_Eviction_mp4.html:36
(Diff revision 1)
>    });
>  }
>  
> +addMSEPrefs(
> +  ["media.mediasource.eviction_threshold.audio", 524288],
> +  ["media.dormant-on-pause-timeout-ms", -1] // Disable dormant.

not aligned... extra space line 35

::: dom/media/mediasource/test/test_Eviction_mp4.html:36
(Diff revision 1)
>    });
>  }
>  
> +addMSEPrefs(
> +  ["media.mediasource.eviction_threshold.audio", 524288],
> +  ["media.dormant-on-pause-timeout-ms", -1] // Disable dormant.

Could you please add a comment describing for each test where dormant is disabled, on why it's disabled with a bug created for each of those?

I don't see why dormant should be disabled here, seeing that dormant should be invisible to JS anyway
Attachment #8812641 - Flags: review?(jyavenard) → review+
(Assignee)

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8812641 [details]
Bug 1318982 - Enable dormant for most media mochitests.

https://reviewboard.mozilla.org/r/94288/#review94778

> not aligned... extra space line 35

Can you point me at the space? I can't find it.

> Could you please add a comment describing for each test where dormant is disabled, on why it's disabled with a bug created for each of those?
> 
> I don't see why dormant should be disabled here, seeing that dormant should be invisible to JS anyway

Still figuring out why dormant causes test failures. I will file follow-up bugs.

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8812641 [details]
Bug 1318982 - Enable dormant for most media mochitests.

https://reviewboard.mozilla.org/r/94288/#review94778

> Can you point me at the space? I can't find it.

doh, I don't see it anymore..
(Assignee)

Updated

2 years ago
Blocks: 1319292
(Assignee)

Updated

2 years ago
Blocks: 1319293
(Assignee)

Updated

2 years ago
Blocks: 1319295
Comment hidden (mozreview-request)

Comment 6

2 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af9ac4bc7efd
Enable dormant for most media mochitests. r=jya

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/af9ac4bc7efd
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.