131899 - remove nsA{Readable,Writable}{,C}String

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should remove nsA{Readable,Writable}{,C}String in favor of
{const ,}nsA{,C}String.  This will reduce confusion since there will be fewer
string classes, and it's been the plan for some time.  It's just never been done.

So I did most of the work using sed.  I used the script:

find mozilla -name "*".cpp -o -name "*".h -o -name "*".idl | while read FILENAME; do
  sed -f mass-change.sed $FILENAME > $FILENAME.$$.tmp
  mv $FILENAME.$$.tmp $FILENAME
done

where mass-change.sed contained:

s/const nsAReadableString/const nsAString/g
s/nsAWritableString/nsAString/g
s/const nsAReadableCString/const nsACString/g
s/nsAWritableCString/nsACString/g
s/nsAReadableString/const nsAString/g
s/nsAReadableCString/const nsACString/g
s/"const nsAString\.h"/"nsAString\.h"/

I then manually redid all the changes within string/, and manually cleaned
various things up in the following files:

     + xpcom/ds/nsIAtom.idl
     + netwerk/cache/src/nsCache.cpp
     + netwerk/protocol/about/src/nsAboutRedirector.cpp
     + extensions/transformiix/source/xslt/txMozillaXMLOutput.h
     + content/xsl/document/src/nsXSLContentSink.cpp
     + htmlparser/src/nsDTDUtils.h htmlparser/src/nsHTMLTags.cpp
     + embedding/components/windowwatcher/src/nsPrompt.cpp

A |cvs diff -u| of this tree yielded a 1.3MB file that touches 647 files.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: diff of only the "interesting" files mentioned above

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: complete diff

(gzipped.  Too bad bugzilla doesn't have a way to enter the 'Content-Encoding'
for attachments as well.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Don't review the complete diff yet.  I'll attach a human-corrected version later.

Comment 4

[jag (Peter Annema)]

Comment on attachment 74884 [details] [diff] [review]
diff of only the "interesting" files mentioned above

sr=jag

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: complete patch, corrected

Comment 6

[jag (Peter Annema)]

Comment on attachment 74905 [details]
complete patch, corrected

sr=jag

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

By far the bulk of these changes hit content, editor, accessible,
extensions/xmlextras, and htmlparser (in that order, by number of files), so
cc:ing some people who work on that code in case this is a particularly bad time
to do this.

Comment 8

[Joe Francis]

This is fine with editor folks.

Comment 9

[Aaron Leventhal]

Fine with accessibility folks. 

Comment 10

[Scott Collins]

Comment on attachment 74905 [details]
complete patch, corrected

r=scc

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 74905 [details]
complete patch, corrected

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 74905 [details]
complete patch, corrected

This patch has a mistake in 
mozilla/extensions/python/xpcom/src/VariantUtils.cpp which can be fixed by the
change:

 -#include <nsAReadableString.h>
 -#include <nsAWritableString.h>
-+#include <const nsAString.h>
 +#include <nsAString.h>

Comment 13

[John Bandhauer]

Are you guys planning on changing what is emitted by the xpidl compiler?

Comment 14

[John Bandhauer]

Ah, foolish me. I see that was done months ago.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in, 2002-03-23.