1319009 - View Source shows a blank New Tab

Status: VERIFIED FIXED

(Toolkit :: View Source, defect)

Description

[blinky]

Steps to reproduce:

1. Go to https://bugzilla.mozilla.org/attachment.cgi?id=8803679.
2. Right-click, select "View Page Source".


Actual results:

A blank tab was opened.

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=742ff7058a1efa990fe9eacb1b3c1bdeaad60c6b&tochange=6868b4b3f1ae395fa6b244d9e9406aab1af00771

Regressed by: bug 1315951

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The changes to Places are unlikely to be related.
the problem is instead in the viewSource changes, more specifically

17:53:26.874 NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDocShell.charset] 1 viewSource-content.js:294

in toolkit/components/viewsource/content/viewSource-content.js
previously we were setting forcedCharset to a shadowed variable, so we were basically never setting it.

Looks like a real bug that the eslinting uncovered.

we should use .forcedCharset (cause charset is legacy) and likely try/catch it

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1319009 - View Source shows a blank New Tab with a forced charset.

Review commit: https://reviewboard.mozilla.org/r/94412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94412/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8812825 [details]
Bug 1319009 - View Source shows a blank New Tab with a forced charset.

https://reviewboard.mozilla.org/r/94412/#review94640

Yoink'ing review.

Looks good to me. Thanks mak!

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8812825 [details]
Bug 1319009 - View Source shows a blank New Tab with a forced charset.

https://reviewboard.mozilla.org/r/94412/#review94764

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42c3a09033f0
View Source shows a blank New Tab with a forced charset. r=mconley,mossop

Comment 7

[Hani Yacoub, Desktop QA]

I tested this issue on windows 7 64 bits, I updated the flags because I couldn't reproduce it on the Firefox Nightly 50.0a1 and 52.0a1.

Comment 8

[Alice0775 White]

I can reproduce on Aurora52.0a2[1] and Nightly53.0a1[2].

[1]
https://hg.mozilla.org/releases/mozilla-aurora/rev/a99c9599b45835479e6e18da0614b0652d42435a
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 ID:20161121004022

[2]
https://hg.mozilla.org/integration/mozilla-inbound/rev/a64eaf74ef8b7f201897dbd2c8f982d9a845b532
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 ID:20161121191250

Comment 9

[Hani Yacoub, Desktop QA]

Sorry Alice I only tested this on Nightly 52.0a1, to be sure I tested this on Aurora52.0a2 and I reproduce it also.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42c3a09033f0

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8812825 [details]
Bug 1319009 - View Source shows a blank New Tab with a forced charset.

Approval Request Comment
[Feature/regressing bug #]: bug 1315951
[User impact if declined]: view source doesn't work on pages with a forced charset
[Describe test coverage new/current, TreeHerder]: nightly
[Risks and why]: no risk, just a try/catch
[String/UUID change made/needed]: none

Comment 12

[Marcia Knous [:marcia]]

Tracking 53- since this is resolved fixed.

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8812825 [details]
Bug 1319009 - View Source shows a blank New Tab with a forced charset.

fix view source regression in aurora52

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/50ad21cb103d

Comment 15

[Andrei Vaida [:avaida]]

This is verified fixed on 52.0b8-build1 (20170220070057) & 53.0a2 (2017-02-21), using Windows 10 x64, macOS 10.12.3 and Ubuntu 16.04 x64.