1319015 - Blank ruleview when remote debugging Firefox 49

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Julian Descottes [:jdescottes]]

Regression from Bug 1308467. 

STRs:
- open Firefox 49 (but this should happen with any remote target that requires a normalization of the CSS properties db)
- gcli > listen 6080
- open Firefox 52 or newer
- open WebIDE
- remote connect to localhost:6080
- inspect any tab

AR: Ruleview is blank
ER: Ruleview should not be blank

Comment 1

[Julian Descottes [:jdescottes]]

My bad, when rewriting my patch for Bug 1308467, I introduced a dumb error: all properties listed after 'color' will not be normalized with 'values' and 'supports'.

(FYI I'm not able to even start remote debugging from Nightly to FF 50 at the moment, that's why I mentioned FF 49 in the STRs)

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1319015 - fix css-properties normalization when remote dbg old ff;

Review commit: https://reviewboard.mozilla.org/r/94356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94356/

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8812709 [details]
Bug 1319015 - fix css-properties normalization when remote dbg old ff;

https://reviewboard.mozilla.org/r/94356/#review94502

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the review, try https://treeherder.mozilla.org/#/jobs?repo=try&revision=85e0ed12f5209a406043eff4f7236a6bfb571f7a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/204765519a9a
fix css-properties normalization when remote dbg old ff;r=pbro

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/204765519a9a