Closed Bug 1319024 Opened 3 years ago Closed 3 years ago

Sync default testing preferences for GeckoInstance classes

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

()

Details

(Whiteboard: [blocked by bug 1318644])

Attachments

(2 files)

We are using a lot of additional default preferences in the DesktopGeckoInstance, whereby most of them might also apply to the GeckoInstance because they are universally used (Firefox, Fennec, Thunderbird).

Lets figure out which of those prefs we can move around.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Summary: Fix default preferences for GeckoInstance classes → Sync default testing preferences for GeckoInstance classes
The try push actually failed due to two reasons:

1. It misses the changes from bug 1318644, so preferences formerly set on the GeckoInstance are not seen because they are now on DesktopInstance

2. Fx-ui tests are failing because they also use browser.newtab.url. It has to be removed first.

I will wait with pushing another try build until the dependency has been fixed.
Depends on: 1318644
Attachment #8813295 - Flags: review?(mjzffr)
Attachment #8812787 - Flags: review?(dburns)
Comment on attachment 8812787 [details]
Bug 1319024 - Sync default testing preferences for Marionette.

https://reviewboard.mozilla.org/r/94394/#review95266
Attachment #8812787 - Flags: review?(dburns) → review+
Comment on attachment 8813295 [details]
Bug 1319024 - Remove usage of browser.newtab.url from Firefox Puppeteer.

https://reviewboard.mozilla.org/r/94744/#review95274
Attachment #8813295 - Flags: review?(mjzffr) → review+
I cannot land those changes until the patch on bug 1318644 has been landed again.
Whiteboard: [blocked by bug 1318644]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc0e9c181248
Remove usage of browser.newtab.url from Firefox Puppeteer. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/19c3f546ee34
Sync default testing preferences for Marionette. r=automatedtester
https://hg.mozilla.org/mozilla-central/rev/cc0e9c181248
https://hg.mozilla.org/mozilla-central/rev/19c3f546ee34
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Please land this test-only change also on mozilla-aurora. Please note that the patch on bug 1318644 has to be backported first.
Whiteboard: [blocked by bug 1318644] → [blocked by bug 1318644][checkin-needed-aurora]
https://hg.mozilla.org/releases/mozilla-aurora/rev/4b08cd56a6d4
https://hg.mozilla.org/releases/mozilla-aurora/rev/a2ff5e607f6a
Whiteboard: [blocked by bug 1318644][checkin-needed-aurora] → [blocked by bug 1318644]
You need to log in before you can comment on or make changes to this bug.