Closed
Bug 1319083
Opened 8 years ago
Closed 8 years ago
Relax the Sized trait bound on nsA[C]String::assign/append in the rust bindings
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file)
|
3.14 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This constraint prevented `&str` from being passed as the argument to those methods, despite str implementing `AsRef<[u8]>`.
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: Js5GOrnqtsg
Attachment #8812789 -
Flags: review?(nfroyd)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8812789 [details] [diff] [review] Relax the Sized constraint on nsA[C]String::assign/append Review of attachment 8812789 [details] [diff] [review]: ----------------------------------------------------------------- The language requiring this seems weird to me, but...OK.
Attachment #8812789 -
Flags: review?(nfroyd) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bd8fc8fe4a9d Relax the Sized constraint on nsA[C]String::assign/append, r=froydnj
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bd8fc8fe4a9d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•