Relax the Sized trait bound on nsA[C]String::assign/append in the rust bindings

RESOLVED FIXED in Firefox 53

Status

()

Core
XPCOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Nika, Assigned: Nika)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This constraint prevented `&str` from being passed as the argument to those methods, despite str implementing `AsRef<[u8]>`.
(Assignee)

Comment 1

2 years ago
Created attachment 8812789 [details] [diff] [review]
Relax the Sized constraint on nsA[C]String::assign/append

MozReview-Commit-ID: Js5GOrnqtsg
Attachment #8812789 - Flags: review?(nfroyd)
Comment on attachment 8812789 [details] [diff] [review]
Relax the Sized constraint on nsA[C]String::assign/append

Review of attachment 8812789 [details] [diff] [review]:
-----------------------------------------------------------------

The language requiring this seems weird to me, but...OK.
Attachment #8812789 - Flags: review?(nfroyd) → review+

Comment 3

2 years ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd8fc8fe4a9d
Relax the Sized constraint on nsA[C]String::assign/append, r=froydnj

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bd8fc8fe4a9d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.