Closed Bug 1319118 Opened 3 years ago Closed 3 years ago

HttpBaseChannel::AddSecurityMessage clobbers the high 32-bits of the inner window ID

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

Don't clobber half of a 64-bit window ID by assigning it to a 32-bit variable
1021 bytes, patch
mcmanus
: review+
Details | Diff | Splinter Review 
It does so by assigning the window ID, a uint64_t to a uint32_t and then passing it to nsIScriptError::InitWithWindowId which accepts a uint64_t.
Blocks: 1092055
Assignee: nobody → ehsan
This is the textbook use case for the auto keyword. :)
Attachment #8812817 - Flags: review?(mcmanus)
Comment on attachment 8812817 [details] [diff] [review]
Don't clobber half of a 64-bit window ID by assigning it to a 32-bit variable

Review of attachment 8812817 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #8812817 - Flags: review?(mcmanus) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11d1733837fa
Don't clobber half of a 64-bit window ID by assigning it to a 32-bit variable; r=mcmanus
Whiteboard: [necko-active]
https://hg.mozilla.org/mozilla-central/rev/11d1733837fa
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.