HttpBaseChannel::AddSecurityMessage clobbers the high 32-bits of the inner window ID
RESOLVED
FIXED
in Firefox 53
Status
()
People
(Reporter: Ehsan, Assigned: Ehsan)
Tracking
Firefox Tracking Flags
(firefox53 fixed)
Details
(Whiteboard: [necko-active])
Attachments
(1 attachment)
|
1021 bytes,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
It does so by assigning the window ID, a uint64_t to a uint32_t and then passing it to nsIScriptError::InitWithWindowId which accepts a uint64_t.
|
(Assignee) | |
Updated•2 years ago
|
||
Assignee: nobody → ehsan
|
|
(Assignee) | |
Comment 1•2 years ago
|
||
Created attachment 8812817 [details] [diff] [review] Don't clobber half of a 64-bit window ID by assigning it to a 32-bit variable This is the textbook use case for the auto keyword. :)
Attachment #8812817 -
Flags: review?(mcmanus)
|
||
Comment 2•2 years ago
|
||
Comment on attachment 8812817 [details] [diff] [review] Don't clobber half of a 64-bit window ID by assigning it to a 32-bit variable Review of attachment 8812817 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8812817 -
Flags: review?(mcmanus) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/11d1733837fa Don't clobber half of a 64-bit window ID by assigning it to a 32-bit variable; r=mcmanus
Whiteboard: [necko-active]
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/11d1733837fa
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•