Closed Bug 1319150 Opened 3 years ago Closed 3 years ago

Services.prefs shim addObserver does not handle function case properly

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Iteration:
53.1 - Nov 28
Tracking Status
firefox53 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file)

It turns out that Services.prefs.addObserver can be passed a function,
not just an observable; and that devtools relies on this.
The shim doesn't currently handle this case, but it should.
Iteration: --- → 53.1 - Nov 28
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [reserve-html]
Comment on attachment 8812863 [details]
Bug 1319150 - allow function-style observers in Services shim;

https://reviewboard.mozilla.org/r/94428/#review94674

This looks good to me, thanks for the fix Tom!
Attachment #8812863 - Flags: review?(jdescottes) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4e90ea16802
allow function-style observers in Services shim; r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/f4e90ea16802
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
This issue is marked with the qe-verify? flag. If it needs manual QA, can you please provide some guidelines in order for us to verify it on Firefox 53 beta? Thank you!
Flags: needinfo?(ttromey)
I don't think this really needs QA.
It's not visible except in an unusual setup.
Flags: needinfo?(ttromey)
Flags: qe-verify?
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.