Closed Bug 1319150 Opened 3 years ago Closed 3 years ago
.prefs shim add Observer does not handle function case properly
58 bytes, text/x-review-board-request
It turns out that Services.prefs.addObserver can be passed a function, not just an observable; and that devtools relies on this. The shim doesn't currently handle this case, but it should.
Iteration: --- → 53.1 - Nov 28
Priority: -- → P1
Comment on attachment 8812863 [details] Bug 1319150 - allow function-style observers in Services shim; https://reviewboard.mozilla.org/r/94428/#review94674 This looks good to me, thanks for the fix Tom!
Attachment #8812863 - Flags: review?(jdescottes) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f4e90ea16802 allow function-style observers in Services shim; r=jdescottes
This issue is marked with the qe-verify? flag. If it needs manual QA, can you please provide some guidelines in order for us to verify it on Firefox 53 beta? Thank you!
I don't think this really needs QA. It's not visible except in an unusual setup.
You need to log in before you can comment on or make changes to this bug.