Closed Bug 1319174 Opened 3 years ago Closed 3 years ago

Cleanup content vs. skin CSS separation for insecure password field

Categories

(Firefox :: Theme, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file)

Some of the CSS properties for "insecureWarning" styles added in browser/base/content/browser.css belong in browser/themes/shared/autocomplete.inc.css as they are theme related.
Priority: -- → P2
Comment on attachment 8812888 [details]
Bug 1319174 - Cleanup content vs. skin CSS separation for the insecure password field.

https://reviewboard.mozilla.org/r/94442/#review94696

Good catch! I think this made it to 52, so don't forget the uplift request.
Attachment #8812888 - Flags: review?(mconley) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/9f88b41193c6
Cleanup content vs. skin CSS separation for the insecure password field. r=mconley
Comment on attachment 8812888 [details]
Bug 1319174 - Cleanup content vs. skin CSS separation for the insecure password field.

Approval Request Comment
[Feature/regressing bug #]: bug 1217162
[User impact if declined]: Third-party themes may have a harder time styling the warning
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Low risk trivial change 
[String/UUID change made/needed]: None
Attachment #8812888 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9f88b41193c6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment on attachment 8812888 [details]
Bug 1319174 - Cleanup content vs. skin CSS separation for the insecure password field.

css change for easier theming, take in aurora52
Attachment #8812888 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.