1319200 - Firefox for Android sending GMP update requests to Balrog with bad versions

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[[e-mail] (:bhearsum)]

I'm not sure if we're supposed to be sending GMP update requests from Fennec or not, but we're seeing tons of requests to Balrog with URLs such as: https://aus5.mozilla.org/update/3/GMP/2.2.1_r563M/20160505202908/Android_arm-eabi-gcc3/en-US/default/Linux%2023/default/default/update.xml

If we're not supposed to send these, we should disable them. If we are, we should fix the %VERSION% section to send the Fennec version instead of 2.2.1_r563M (I'm guessing this is a gonk version or something?).

Not quite sure who to cc on this, so feel free to redirect.

Comment 1

[Robert Strong (they/them - no direct email)]

Not sure if they can help but there were a few people that worked on gmp in bug 1267495.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
> Not sure if they can help but there were a few people that worked on gmp in
> bug 1267495.

I think it's probably unrelated, Ben did this only start happening recently?

I don't know if we serve any media plugins to Android or if we plan to, but the version issue should be fixed in any case.

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Robert Helmer [:rhelmer] from comment #2)
> (In reply to Robert Strong [:rstrong] (use needinfo to contact me) from
> comment #1)
> > Not sure if they can help but there were a few people that worked on gmp in
> > bug 1267495.
> 
> I think it's probably unrelated, Ben did this only start happening recently?
> 
> I don't know if we serve any media plugins to Android or if we plan to, but
> the version issue should be fixed in any case.

We've been seeing it since we turned on Sentry ~1 month ago, it likely goes back further...but I don't have any logs to tell you when beyond that :(.

Comment 4

[Richard Newman [:rnewman]]

We're supposed to send GMP pings. See Bug 1193965.

2.2.1 sounds like an Android version. The pref is

modules/libpref/init/all.js
5335:pref("media.gmp-manager.url", "https://aus5.mozilla.org/update/3/GMP/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xm

I see GMPInstallManager calls UpdateUtils.formatUpdateURL.

UpdateUtils looks like it does the right thing, assuming that Services.appinfo.version is correct.

Comment 5

[Richard Newman [:rnewman]]

Are you able to get a list of %VERSION%, %BUILD_ID% pairs? I'm interested to see if this is still going on.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Fabrice is likely a good person to talk to. Adding him as a cc.

Comment 7

[[e-mail] (:bhearsum)]

I'm struggling to get version+buildid pairs out of Sentry right now, but I'll see what I can do. In the meantime here's a copy/paste of few requests showing up there:
Browser	Device	Level	OS	Server	URL	User
Firefox Mobile 43.0	Generic Smartphone	error	Android 5.1	ip-172-31-44-40	https://aus5.mozilla.org/update/3/GMP/2.2.1_r563M/20160505202908/Android_arm-eabi-gcc3/en-US/default/Linux 22/default/default/update.xml	
Firefox Mobile 43.0	Generic Smartphone	error	Android 5.1.1	ip-172-31-19-142	https://aus5.mozilla.org/update/3/GMP/2.2.1_r570/20160527093228/Android_arm-eabi-gcc3/en-US/default/Linux 22/default/default/update.xml	
Firefox Mobile 39.0	Generic Smartphone	error	Android	ip-172-31-19-142	https://aus5.mozilla.org/update/3/GMP/39.0.1a/20150715012346/Android_arm-eabi-gcc3/en-US/no/Linux 19/default/default/update.xml	
Firefox Mobile 39.0	Generic Smartphone	error	Android	ip-172-31-44-40	https://aus5.mozilla.org/update/3/GMP/39.0.1a/20150715012346/Android_arm-eabi-gcc3/en-US/no/Linux 22/default/default/update.xml	
Firefox Mobile 39.0	Generic Smartphone	error	Android	ip-172-31-45-178	https://aus5.mozilla.org/update/3/GMP/39.0.1a/20150715012346/Android_arm-eabi-gcc3/en-US/no/Linux 19/default/default/update.xml	
Firefox Mobile 39.0	Generic Smartphone	error	Android	ip-172-31-32-233	https://aus5.mozilla.org/update/3/GMP/39.0.1a/20150715012346/Android_arm-eabi-gcc3/en-US/no/Linux 22/default/default/update.xml	
Firefox Mobile 43.0	Generic Smartphone	error	Android 4.4.2	ip-172-31-2-41	https://aus5.mozilla.org/update/3/GMP/2.2.1_r570/20160527093228/Android_arm-eabi-gcc3/en-US/default/Linux 19/default/default/update.xml

The "Browser" column comes from User Agent, so it looks like we can rely on that for version (example: Mozilla/5.0 (Android 5.1; Mobile; rv:43.0) Gecko/43.0 Firefox/43.0). So far, I only see 43.0 and 39.0 in there, but I've only looked at <100 reported events.

Comment 8

[[e-mail] (:bhearsum)]

OK, I've been over all the requests for the past month and can't find any sending bad versions that weren't 39.0 or 43.0. Strange that it would be only those two, but it seems unlikely that it's still happening.

Comment 9

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #8)
> OK, I've been over all the requests for the past month and can't find any
> sending bad versions that weren't 39.0 or 43.0. Strange that it would be
> only those two, but it seems unlikely that it's still happening.

Closing because of this. Sorry for the noise folks!