1319213 - Crash in ClientLayerManager::HandleMemoryPressure on GPU process restart

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Example crash: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=31501206

It looks like mWidget might be freed, and the ClientLayerManager has outlived the widget. Am running a try job to see if this is the case.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1319213.patch

Looks like this was indeed the problem.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/25dbaa474141
Fix dangling nsIWidget pointer in ClientLayerManager. (bug 1319213, r=mattwoodrow)

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/25dbaa474141

Comment 5

[Gerry Chang [:gchang]]

Hi :dvander,
could you please nominate this uplift to Beta51 and Aurora52?

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Unless it is known otherwise, this only affects Nightly/53 where the GPU process is enabled.

Comment 7

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8813081 [details] [diff] [review]
bug1319213.patch

Approval Request Comment
[Feature/regressing bug #]: Unknown
[User impact if declined]: Rare crash when layers shuts down
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: No risk
[String/UUID change made/needed]:

Oops, I just saw the other bug where we have crash stacks on 50/51. Sounds like we should uplift this.

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8813081 [details] [diff] [review]
bug1319213.patch

Fix a crash. Beta51+ and Aurora52+. Should be in 51 beta 4.

Comment 9

[Carsten Book [:Tomcat]]

needs rebasing 

grafting 376500:25dbaa474141 "Fix dangling nsIWidget pointer in ClientLayerManager. (bug 1319213, r=mattwoodrow)"
merging gfx/layers/client/ClientLayerManager.cpp
warning: conflicts while merging gfx/layers/client/ClientLayerManager.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a5ac4acad565

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Well, the seemingly-trivial rebase didn't go very well. Backed out.
https://hg.mozilla.org/releases/mozilla-aurora/rev/d55ebc9e509d61125961fa3b68488ce7b370d4eb

https://treeherder.mozilla.org/logviewer.html#?job_id=4335792&repo=mozilla-aurora

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Wes or tomcat - can you try relanding this on aurora and beta now that the patch from bug 1305829 is also landing?  Thanks!

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/236b90305efb

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/99889cdd48aba59b455745bd061dac14b4bd7b45