Closed Bug 1319213 Opened 4 years ago Closed 4 years ago
Crash in Client
Layer Manager::Handle Memory Pressure on GPU process restart
Example crash: https://email@example.com&selectedJob=31501206 It looks like mWidget might be freed, and the ClientLayerManager has outlived the widget. Am running a try job to see if this is the case.
4 years ago
Depends on: 1305829
Looks like this was indeed the problem.
Attachment #8813081 - Flags: review?(matt.woodrow)
Attachment #8813081 - Flags: review?(matt.woodrow) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/25dbaa474141 Fix dangling nsIWidget pointer in ClientLayerManager. (bug 1319213, r=mattwoodrow)
Hi :dvander, could you please nominate this uplift to Beta51 and Aurora52?
Unless it is known otherwise, this only affects Nightly/53 where the GPU process is enabled.
Comment on attachment 8813081 [details] [diff] [review] bug1319213.patch Approval Request Comment [Feature/regressing bug #]: Unknown [User impact if declined]: Rare crash when layers shuts down [Describe test coverage new/current, TreeHerder]: Nightly [Risks and why]: No risk [String/UUID change made/needed]: Oops, I just saw the other bug where we have crash stacks on 50/51. Sounds like we should uplift this.
Comment on attachment 8813081 [details] [diff] [review] bug1319213.patch Fix a crash. Beta51+ and Aurora52+. Should be in 51 beta 4.
needs rebasing grafting 376500:25dbaa474141 "Fix dangling nsIWidget pointer in ClientLayerManager. (bug 1319213, r=mattwoodrow)" merging gfx/layers/client/ClientLayerManager.cpp warning: conflicts while merging gfx/layers/client/ClientLayerManager.cpp! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue (use 'hg resolve' and 'hg graft --continue')
Well, the seemingly-trivial rebase didn't go very well. Backed out. https://hg.mozilla.org/releases/mozilla-aurora/rev/d55ebc9e509d61125961fa3b68488ce7b370d4eb https://treeherder.mozilla.org/logviewer.html#?job_id=4335792&repo=mozilla-aurora
Wes or tomcat - can you try relanding this on aurora and beta now that the patch from bug 1305829 is also landing? Thanks!
3 years ago
You need to log in before you can comment on or make changes to this bug.