1319337 - Make "File bug" function works on awsy and awfy project

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Alison Shiue]

For helping sheriff work on both awsy and awfy project, please help to add "File bug" function to auto generate bugzilla bug.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

We will probably have a different set of policy for AWSY, I guess just coming up with what the template should look like will be the first step here.

Comment 2

[William Lachance (:wlach)]

Something simple based on the build metrics template would be a good start:

https://github.com/mozilla/treeherder/blob/master/treeherder/perf/fixtures/performance_bug_templates.yaml#L25

I don't think we should file bugs without:

(1) A good description of what is being tested
(2) Instructions on how to reproduce

My preference is to put such documentation on developer.mozilla.org (ideally we would move the Talos docs there at some point as well)

Comment 3

[William Lachance (:wlach)]

Hey Shruti, do you want to handle this? This should be pretty trivial. Mostly you can just follow the template from build metrics, just change the names and links.

For AWSY please link to this MDN entry:

https://developer.mozilla.org/en-US/docs/Mozilla/Performance/AWSY

For AWFY please link to this:

https://www.arewefastyet.com/

(the documentation for both could probably be improved but we can take care of that later)

Comment 4

[Shruti Jasoria [:ShrutiJ]]

If I'm not wrong, we can file bugs only for talos?

If yes, I think I'll have to make changes around 

https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/perf/alerts.js#L7

and

https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/perf/alerts.js#L288

Also, the template for the description will go to https://github.com/mozilla/treeherder/blob/master/treeherder/perf/fixtures/performance_bug_templates.yaml ?

Comment 5

[William Lachance (:wlach)]

(In reply to Shruti Jasoria [:ShrutiJ] from comment #4)
> If I'm not wrong, we can file bugs only for talos?
> 
> If yes, I think I'll have to make changes around 
> 
> https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/perf/
> alerts.js#L7
> 
> and
> 
> https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/perf/
> alerts.js#L288
> 
> Also, the template for the description will go to
> https://github.com/mozilla/treeherder/blob/master/treeherder/perf/fixtures/
> performance_bug_templates.yaml ?

Yes, you can remove the "Talos" part of the fileTalosBug function in your PR. :) Probably should never have named it that in the first place.

Comment 6

[GitHub Autolander Bot]

Attachment: [treeherder] SJasoria:Bug1319337 > mozilla:master

Comment 7

[Shruti Jasoria [:ShrutiJ]]

Comment on attachment 8868679 [details] [review]
[treeherder] SJasoria:Bug1319337 > mozilla:master

I have made a few changes but I'm unable to test them. Please take a look at it and let me know if any changes have to it.

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8868679 [details] [review]
[treeherder] SJasoria:Bug1319337 > mozilla:master

Good stuff!

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/442f652c9a30ffd8f071f08a3834502ec5e6ad8b
Bug 1319337 - Make file bug function work on awsy and awfy project (#2484)