Closed Bug 1319343 Opened 3 years ago Closed 3 years ago

Remove unused directory layout/svg/tests

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

tl;dr: let's remove some cruft.

We have a directory layout/svg/tests, which only has a single non-automated SVG testcase (and a stylesheet for that testcase). It seems to be an early SVG demo.

This folder hasn't been touched since the year 2000...
   https://github.com/mozilla/gecko-dev/tree/master/layout/svg/tests
...and it's extremely bogus. For example:

 (1) The SVG content starts with the wrong namespace:

> <svg xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.svg"
(Note this "there.is.only.svg"  namespace -- it should be http://www.w3.org/2000/svg" )

 (2) It doesn't render anything, as a result of (1).

 (3) It has (overlapping) Start/Stop buttons to make some sort of dynamic tweak, but if I click Start, I get "InUseAttributeError: Attribute already in use"

Let's just get rid of this directory. I mistakenly stepped into it when looking for a place to add a SVG mochitest, so it's confusing for it to be present with crufty old junk.
Attachment #8813045 - Flags: review?(longsonr)
Comment on attachment 8813045 [details] [diff] [review]
fix v1: remove the files & directory

No need to worry about this directory being left empty, btw -- this patch removes the directory as well, because mercurial automatically deletes empty directories:
 http://stackoverflow.com/questions/3917275/hg-remove-directory-from-repo
Attachment #8813045 - Attachment description: fix v1: remove the files → fix v1: remove the files & directory
As a sanity check to prove that nothing cares about this "test" or its directory, here's a Try run with all unit tests, on 1 platform (Mac):
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=642f9c16318eaff8cc8adbdfc4d154a3b356c857
(FWIW, bug 1319428 removes another unused file, and another layout/svg subdirectory ("resources"). Adding to "see also", since these are both cleaning up unused stuff in layout/svg)
See Also: → 1319428
Attachment #8813045 - Flags: review?(longsonr) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d16912005e86
Remove unused & broken SVG testcase/demo from layout/svg/tests. r=longsonr
https://hg.mozilla.org/mozilla-central/rev/d16912005e86
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.