Closed
Bug 1319345
Opened 4 years ago
Closed 4 years ago
Change how application.ini and application.ini.h are generated
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•4 years ago
|
Blocks: more-faster
Comment 3•4 years ago
|
||
mozreview-review |
Comment on attachment 8813050 [details] Bug 1319345 - Add flags to GENERATED_FILES. https://reviewboard.mozilla.org/r/94570/#review95026
Attachment #8813050 -
Flags: review?(mshal) → review+
Comment 4•4 years ago
|
||
mozreview-review |
Comment on attachment 8813051 [details] Bug 1319345 - Change how application.ini and application.ini.h are generated. https://reviewboard.mozilla.org/r/94572/#review95028 ::: build/moz.build:30 (Diff revision 1) > +} > + > for var in ('GRE_MILESTONE', 'MOZ_APP_VERSION', 'MOZ_APP_BASENAME', > 'MOZ_APP_VENDOR', 'MOZ_APP_ID', 'MAR_CHANNEL_ID', > - 'ACCEPTED_MAR_CHANNEL_IDS', 'MOZ_APP_REMOTINGNAME'): > - DEFINES[var] = CONFIG[var] > + 'MOZ_APP_REMOTINGNAME'): > + appini_defines[var] = CONFIG[var] Since appini_defines are now only used by the application.ini generation, they can be moved inside the if CONFIG['MOZ_APP_BASENAME'] block.
Attachment #8813051 -
Flags: review?(mshal) → review+
Comment hidden (mozreview-request) |
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/861e47bdfa2b Add flags to GENERATED_FILES. r=mshal https://hg.mozilla.org/integration/autoland/rev/d4006c73e308 Change how application.ini and application.ini.h are generated. r=mshal
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20c0572d2e46 application.ini fixup for artifact build bustage; r=gps
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/861e47bdfa2b https://hg.mozilla.org/mozilla-central/rev/d4006c73e308 https://hg.mozilla.org/mozilla-central/rev/20c0572d2e46
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•