Closed Bug 1319350 Opened 3 years ago Closed 3 years ago
Add dedicated targets for some one-offs in the build
58 bytes, text/x-review-board-request
No description provided.
Comment on attachment 8813055 [details] Bug 1319350 - Add dedicated targets for some one-offs in the build. https://reviewboard.mozilla.org/r/94576/#review95030 See also https://bugzilla.mozilla.org/show_bug.cgi?id=1301148#c23 - I'll let you two work out landing things to avoid breaking each other. ::: accessible/interfaces/ia2/Makefile.in:78 (Diff revision 1) > INSTALL_TARGETS += midl > midl_FILES := $(filter %.h %_i.c,$(MIDL_GENERATED_FILES)) > midl_DEST = $(DIST)/include > -midl_TARGET := export > +midl_TARGET := midl > + > +export:: midl Is there a reason you want the ipdl target to be PHONY but not the midl target?
Attachment #8813055 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #2) > Is there a reason you want the ipdl target to be PHONY but not the midl > target? There is a ipdl subdirectory in ipc/ipdl. Without .PHONY, the rule doesn't do anything because the directory exists.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4215cd6d8d55 Add dedicated targets for some one-offs in the build. r=mshal
You need to log in before you can comment on or make changes to this bug.