Closed Bug 1319352 Opened 4 years ago Closed 4 years ago

Allow to run AccEventGen.py and xpidl/header.py from any directory

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8813058 [details]
Bug 1319352 - Allow to run AccEventGen.py and xpild/header.py from any directory.

https://reviewboard.mozilla.org/r/94584/#review95040

::: xpcom/idl-parser/xpidl/header.py:551
(Diff revision 1)
>  
>      fd.write(iface_template_epilog)
>  
>  
>  def main(outputfile):
> -    cachedir = '.'
> +    cachedir = os.path.dirname(outputfile.name) if outputfile else '.'

This doesn't seem to work in the recursive make backend - outputfile.name is defined, but dirname returns an empty string which results in: OSError: [Errno 2] No such file or directory: ''
Attachment #8813058 - Flags: review?(mshal) → review-
Comment on attachment 8813058 [details]
Bug 1319352 - Allow to run AccEventGen.py and xpild/header.py from any directory.

https://reviewboard.mozilla.org/r/94584/#review95050
Attachment #8813058 - Flags: review?(mshal) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/1e0adeab3951
Allow to run AccEventGen.py and xpild/header.py from any directory. r=mshal
https://hg.mozilla.org/mozilla-central/rev/1e0adeab3951
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.