Open Bug 1319380 Opened 7 years ago Updated 6 months ago

Add compilation time to JitSpewer IonScript compile log message

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

defect

Tracking

()

People

(Reporter: sandervv, Unassigned)

Details

Attachments

(1 file)

This is a small patch that adds the duration of compiling an IonScript to the JitSpewer's log message. The compilation time includes inlining other scripts.

This makes it easy to see if there is a lot of time spent compiling for certain methods.
Any reasons not to use the TraceLogger for that?
Upon failure I often use IONFLAGS=scripts to know which script started to compile. Ergo giving me in which function the failure happened. By only giving that information after finishing IonBuilder might be annoying for me.

What about only giving the output during linking? It would give basic information, without the need for TraceLogger. TraceLogger can be used in more advanced cases. Like knowing which pass took the most time etc...

[IonScripts] Compiling script self-hosted:7 (0xf641f160) (warmup-counter=1, level=Optimization_Normal)
[IonScripts] Finished script self-hosted:7 (ionbuilder: 15ms, optimizing: 100ms, linking: 12ms)
Comment on attachment 8813104 [details]
Bug 1319380 - Add compilation time to JitSpewer IonScript log message

https://reviewboard.mozilla.org/r/94632/#review95222

I have also used IONFLAGS=scripts to find out which script we're currently compiling. Maybe the nicest/simplest option is to add a separate spew channel for compilation time.

If TraceLogger doesn't give you the information you're looking for, maybe we can write a script to read TL data and print a summary so it can be used in the shell?
Attachment #8813104 - Flags: review?(jdemooij)
Priority: -- → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: