1319389 - Skia assumes powerpc is big endian

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mike Hommey [:glandium]]

Powerpc can run as little-endian and there are now ports that default to this mode. But building Skia assumes powerpc is big-endian, and the build fails with the message "Skia gpu currently assumes little endian".

Comment 1

[Mike Hommey [:glandium]]

I'm not sure how this is supposed to be submitted upstream considering their CLA policy. We have a corporate CLA don't we? How do we use it?

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1319389 - Generically set SK_CPU_[BL]ENDIAN based on __BYTE_ORDER__ when available.

Review commit: https://reviewboard.mozilla.org/r/94660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94660/

Comment 3

[Lee Salzman [:lsalzman]]

Comment on attachment 8813136 [details]
Bug 1319389 - Generically set SK_CPU_[BL]ENDIAN based on __BYTE_ORDER__ when available.

https://reviewboard.mozilla.org/r/94660/#review96154

Comment 4

[Lee Salzman [:lsalzman]]

Upstream bug report: https://skia-review.googlesource.com/c/5280/

Comment 5

[Mike Hommey [:glandium]]

Should I add a patch file somewhere before landing this?

Comment 6

[Lee Salzman [:lsalzman]]

(In reply to Mike Hommey [:glandium] from comment #5)
> Should I add a patch file somewhere before landing this?

I already got this upstreamed just now, so it's clear to land. No patch funniness required.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a1e74ffb4fe
Generically set SK_CPU_[BL]ENDIAN based on __BYTE_ORDER__ when available. r=lsalzman

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a1e74ffb4fe

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 8813136 [details]
Bug 1319389 - Generically set SK_CPU_[BL]ENDIAN based on __BYTE_ORDER__ when available.

Approval Request Comment
[Feature/Bug causing the regression]: regression from some skia update
[User impact if declined]: Build failure on little-endian powerpc. I want to avoid having to carry this patch in Debian for the esr52 cycle.
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: no
[Why is the change risky/not risky?]: NPOTB
[String changes made/needed]: none

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8813136 [details]
Bug 1319389 - Generically set SK_CPU_[BL]ENDIAN based on __BYTE_ORDER__ when available.

skia endian detection fix, beta52+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a1f355b27a45

Comment 12

[Andrei Vaida [:avaida]]

Setting qe-verify- per Comment 9.