Closed Bug 1319396 Opened 3 years ago Closed 3 years ago

Update the list of checkers in .clang-tidy file

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

As part of the initiative to convert gecko to C++11, I would like to update the .clang-tidy file with the checkers that Andi and myself are using.

I am also proposing to remove misc-use-override as modernize-use-override is doing the same but can also manage auto replacement.
Comment on attachment 8813143 [details]
Bug 1319396 - Update the list of checkers in the .clang-tidy file

https://reviewboard.mozilla.org/r/94668/#review94938
Attachment #8813143 - Flags: review?(ehsan) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e262535fc73
Update the list of checkers in the .clang-tidy file r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/2e262535fc73
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee: nobody → sledru
What is the preferred replacement for NS_IMETHOD Method() override to avoid
Warning: 'virtual' is redundant since the function is already declared 'override' [clang-tidy: modernize-use-override]?

Would nsresult Method() override pick up __stdcall from the base class virtual?
NS_IMETHODIMP Method() override would work I guess, but seems out of character, at least for a declaration that is not a definition.

Thanks!
Flags: needinfo?(sledru)
(In reply to Karl Tomlinson (:karlt) from comment #5)
> What is the preferred replacement for NS_IMETHOD Method() override to avoid
> Warning: 'virtual' is redundant since the function is already declared
> 'override' [clang-tidy: modernize-use-override]?
> 
> Would nsresult Method() override pick up __stdcall from the base class
> virtual?
> NS_IMETHODIMP Method() override would work I guess, but seems out of
> character, at least for a declaration that is not a definition.
> 
> Thanks!

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1420366, we are planning to remove it.
Flags: needinfo?(sledru)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.