1319469 - Port bug 1305453 [Prevent non-esr stand alone installers from installing on XP/Vista (Fx53 and up) ]

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Richard Marti (:Paenglab)]

From bug 1305453:
(In reply to Jim Mathies [:jimm] from comment #0)
> We plan to eol XP/Vista by first moving those users out to ESR 52. Once 52
> merges to aurora, we should land changes to the stand alone installer to
> prevent install by XP and Vista users. Initially there shouldn't be an issue
> with running but eventually we'll import a system dependency that will break
> browser startup.

Comment 1

[Richard Marti (:Paenglab)]

FX changesets as reference:

https://hg.mozilla.org/mozilla-central/rev/af88a04128f6
https://hg.mozilla.org/mozilla-central/rev/86a19f0dfa67

Comment 2

[Richard Marti (:Paenglab)]

Attachment: noXPInstaller.patch

This is a simple port of the FX patch.

Jörg, I know you are not a installer specialist. But do we have one? I have nothing added, only ported.

Aryx, can you check all is okay? Thanks.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: error.png

Error message on XP. By clicking on "Ok" I get the system requirements page of TB 45.5.0. But in FX bug there was the page of FX 50 and not 53. So this should be okay.

Comment 4

[Richard Marti (:Paenglab)]

Forgot the link to try build for the installer: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a1588d0c9330a2a5b9f2aabe96765ad93de68da8

The orange is because of check-sync-dir.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8813369 [details] [diff] [review]
noXPInstaller.patch

Review of attachment 8813369 [details] [diff] [review]:
-----------------------------------------------------------------

Philipp (:Fallen) is build peer, I don't know whether that covers installers.
I checked that you merged the two FF changesets correctly. I would be good to actually try an installer ;-)
r=jorgk.

Comment 6

[Richard Marti (:Paenglab)]

You can find the installer from the try build: https://archive.mozilla.org/pub/thunderbird/try-builds/[e-mail]-a1588d0c9330a2a5b9f2aabe96765ad93de68da8/

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8813369 [details] [diff] [review]
noXPInstaller.patch

Can test the Try installers tomorrow (on XP).

Comment 8

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/6480f759875b48d9c9f4a98087cbe09be1fa4713

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks, I'll try a Daily installer later today. I hope we get more feedback from Sebastian.

Comment 10

[Richard Marti (:Paenglab)]

I tried the installer on XP. The screenshot (attachment 8813371 [details]) is from this try.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thanks, attempt to install it on Win XP created the same popup like in comment 10.