1319529 - The unblocking icon didn't be hided when resuming Flash

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Open in a new tab via context menu, http://www.freep.com/story/sports/nba/pistons/2016/11/22/detroit-pistons-downtown/94279874/
See media autoplay blocked icon in the tab
Change to the freep.com tab
Using that tab, navigate to https://bugzilla.mozilla.org

ER:
The autoplay-blocked icon should have been removed

AR:
It isn't removed.

Comment 1

[Simona Badau, Desktop QA]

I also stumbled upon this issue on the latest Nightly 53 (Build ID: 20161122030216) with the following STR:

1. Launch Nightly
2. Navigate to:
http://www.be-at.tv/brands/the-record-loft/wax-hounds-with-sven-weisemann/record-loft-djs
3. In the right side, hover your mouse over any video, right click  and select Open Link in New Tab
4. After the Play Tab button is displayed, focus the tab opened in the previous step
5. Ctrl+L to focus the address bar and navigate to:
https://bugzilla.mozilla.org

Expected results:
The Tab Play button should not be displayed once the tab is focused in step 4.

Actual results:
The Tab Play button is still displayed after the tab is focused in step 4
The Tab Play button persists in step 5 when navigating to a different site.

Comment 2

[Alastor Wu [:alwu]]

The issue described in comment1 would be solved in bug1318462.

Comment 3

[Alastor Wu [:alwu]]

I can't reproduce the issue in comment0, it doesn't show the blocking icon when I open new tab for "freep.com". 

But the issue in comment1 still exists, and I'll fix.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1319529 - notify audible state changed for nsNPAPI.

When the nsNPAPI is muted by AudioChannelService, we should notify our audible state changed.

Review commit: https://reviewboard.mozilla.org/r/99088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99088/

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8819246 [details]
Bug 1319529 - notify audible state changed for nsNPAPI.

https://reviewboard.mozilla.org/r/99088/#review99710

Comment 6

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd51835fff88dd472799789e42691f2c3ab1d7b0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/207f132f1427
notify audible state changed for nsNPAPI. r=baku

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/207f132f1427

Comment 9

[Simona Badau, Desktop QA]

Attachment: screencast

I can still reproduce this issue on Ubuntu 16.04 using the latest Nightly 53.0a1 (Build ID: 20170108030212)
Please note that I can't reproduce the issue on Windows 10 x64 and Mac OS X 10.11.

STR:
1. Open http://www.be-at.tv/brands/the-record-loft/wax-hounds-with-sven-weisemann/record-loft-djs in a background tab
2. Focus the tab opened in step 1 and then focus the URL Bar (Ctrl+L)
3. Navigate to bugzilla.mozilla.org

Expected results:
The Play tab icon should not persist after the tab is in focus.

Actual results:
The play tab icon remains after focusing the tab and persists after navigating further.
Please see the attached screencast for more details.

Comment 10

[Alastor Wu [:alwu]]

Close this bug because it seems caused by different root cause (linux-specific).
I open the bug1330195 for tracking.

Comment 11

[Alastor Wu [:alwu]]

Uplift flag.

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 8819246 [details]
Bug 1319529 - notify audible state changed for nsNPAPI.

Approval Request Comment
[Feature/Bug causing the regression]: This patch allow nsNPAPI to notify audio channel service when it changes the audible state
[User impact if declined]: The "play tab" icon won't be hided when nsNPAPI was resumed 
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: only affect UX
[String changes made/needed]: no

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8819246 [details]
Bug 1319529 - notify audible state changed for nsNPAPI.

properly update audible state for npapi plugins, aurora52+

Comment 14

[Simona Badau, Desktop QA]

Considering Comment 9 and 10, setting status-firefox53: to verified.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b40c51bcd208