1319567 - Fix fill-browser-data regression

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Shane Caraveo (:mixedpuppy)]

Bug 1317101 changed fill-browser-data in a way that breaks running a test *when run solo* that uses browser.windows.getCurrent before any other browser.windows use, by assuming windowId > 0.  Best to avoid future issues and initialize the first id to 1.

Comment 1

[Shane Caraveo (:mixedpuppy)]

or use outer id

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1319567 fix window id so it is never zero,

Review commit: https://reviewboard.mozilla.org/r/94826/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94826/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8813430 [details]
Bug 1319567 fix window id so it is never zero,

https://reviewboard.mozilla.org/r/94826/#review95054

::: browser/components/extensions/ext-utils.js:967
(Diff revision 1)
>      if (this._windows.has(window)) {
>        return this._windows.get(window);
>      }

No need for the WeakMap anymore. Just return the outer window ID directly.

::: browser/components/extensions/ext-utils.js:970
(Diff revision 1)
>  
>    getId(window) {
>      if (this._windows.has(window)) {
>        return this._windows.get(window);
>      }
> -    let id = this._nextId++;
> +    let id = window.QueryInterface(Ci.nsIInterfaceRequestor).

Move dot to the start of next line, please.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8813430 [details]
Bug 1319567 fix window id so it is never zero,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94826/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15ab89563679
fix window id so it is never zero, r=kmag

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This appears to have caused browser-chrome failures like https://treeherder.mozilla.org/logviewer.html#?job_id=7061850&repo=autoland

Backed out in https://hg.mozilla.org/integration/autoland/rev/e52d162e55a32d6f9a905ab1eb4831f0bb98593f

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8813430 [details]
Bug 1319567 fix window id so it is never zero,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/94826/diff/2-3/

Comment 8

[Shane Caraveo (:mixedpuppy)]

Ok, fixed that issue, re-landing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4010d412d8c5
fix window id so it is never zero, r=kmag

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4010d412d8c5