Closed
Bug 1319569
Opened 8 years ago
Closed 7 years ago
Dead code in videocontrols.xml
Categories
(Toolkit :: Video/Audio Controls, defect)
Toolkit
Video/Audio Controls
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: Dolske, Assigned: ralin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
8.75 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
I believe the entirety of the <binding id="timeThumb"/> can now be removed as it's unused, now that the bug 1271765 visual refresh no longer uses the time-in-the-thumb UI.
|
Reporter | |
Comment 1•8 years ago
|
||
(also the associated -moz-binding in videocontrols.css)
|
|
Reporter | |
Comment 2•8 years ago
|
||
(Also also, I just noticed, the "/* Statistics formatting */" in the other videocontrols.css has also been dead for a while.)
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ralin
| Comment hidden (mozreview-request) |
|
||
Updated•8 years ago
|
Assignee: ralin → jaws
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•8 years ago
|
||
discussed with Jared on IRC. This patch is based on previous one and fix crash on mobile due to `thumb`. Also, I removed the type check about `type == "scrubber"` since there's no other type of <slider> on mobile controls. And, we adjust controls by javascript instead of assigning different size attribute after bug 1271765, so I deleted the corresponding CSS rules as well.
Attachment #8819264 -
Flags: review?(jaws)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8819264 [details] [diff] [review] Bug-1319569-Remove-unused-timeThumb-binding-in-video.patch Review of attachment 8819264 [details] [diff] [review]: ----------------------------------------------------------------- This looks good, thank you. Please push your review requests to MozReview in the future :)
Attachment #8819264 -
Flags: review?(jaws) → review+
|
|
||
Updated•8 years ago
|
Attachment #8819191 -
Attachment is obsolete: true
Attachment #8819191 -
Flags: review?(ralin)
|
|
||
Updated•8 years ago
|
Assignee: jaws → ralin
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/449c5354f001 Remove unused timeThumb binding in videocontrols.xml and unreferenced statistics formatting styling from videocontrols.css. r=jaws
Keywords: checkin-needed
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/449c5354f001
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•