Closed Bug 1319595 Opened 5 years ago Closed 5 years ago

Fix non-cxx/ IPDL unit tests

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(7 files)

There are a number of tests in the ipc/ipdl/test/ipdl/ directory that are broken, for various reasons. Clearly nobody has run these in the last few years. I'm going to fix up these tests. Bill also said I could just delete tests relating to the state machine and opens/spawns stuff.

One set of these tests, in error/, have their own special set of problems, because the test suite currently only checks that the test fails, but not why. This has lead to things like a change accidentally dropping a semi-colon, so instead of testing whatever it is supposed to test it is just failing in a syntax error. So we need some kind of expected failure testing. I'll probably put that in a separate bug and just fix up obviously broken things for now.
Blocks: 1319620
I have a stack of patches that seems to fix things up locally. I'll make sure it doesn't break anything on try.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=30d1a06f018476d38cf5c0758bb09a7a637f3ca2
Comment on attachment 8813750 [details]
Bug 1319595, part 1 - Remove IPDL error tests involving state machine or bridge/open.

https://reviewboard.mozilla.org/r/95136/#review96190
Attachment #8813750 - Flags: review?(wmccloskey) → review+
Comment on attachment 8813751 [details]
Bug 1319595, part 2 - Add async annotations to IPDL unit tests.

https://reviewboard.mozilla.org/r/95138/#review96192
Attachment #8813751 - Flags: review?(wmccloskey) → review+
Comment on attachment 8813752 [details]
Bug 1319595, part 3 - Allow including a type twice as long as it is from the same file both times.

https://reviewboard.mozilla.org/r/95140/#review96196
Attachment #8813752 - Flags: review?(wmccloskey) → review+
Comment on attachment 8813753 [details]
Bug 1319595, part 4 - Fix type checker handling of end points without qualifiers.

https://reviewboard.mozilla.org/r/95142/#review96200
Attachment #8813753 - Flags: review?(wmccloskey) → review+
Comment on attachment 8813754 [details]
Bug 1319595, part 5 - Rename rpc to interrupt in IPDL error/ unit tests.

https://reviewboard.mozilla.org/r/95144/#review96202
Attachment #8813754 - Flags: review?(wmccloskey) → review+
Comment on attachment 8813755 [details]
Bug 1319595, part 6 - Fix various IPDL tests.

https://reviewboard.mozilla.org/r/95146/#review96204
Attachment #8813755 - Flags: review?(wmccloskey) → review+
Comment on attachment 8813756 [details]
Bug 1319595, part 7 - Remove obsolete test.

https://reviewboard.mozilla.org/r/95148/#review96206
Attachment #8813756 - Flags: review?(wmccloskey) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a84f47c9a0e0
part 1 - Remove IPDL error tests involving state machine or bridge/open. r=billm
https://hg.mozilla.org/integration/autoland/rev/483bea1e5092
part 2 - Add async annotations to IPDL unit tests. r=billm
https://hg.mozilla.org/integration/autoland/rev/d056bbc15cf8
part 3 - Allow including a type twice as long as it is from the same file both times. r=billm
https://hg.mozilla.org/integration/autoland/rev/86796aaaf1f2
part 4 - Fix type checker handling of end points without qualifiers. r=billm
https://hg.mozilla.org/integration/autoland/rev/967d7be10d7a
part 5 - Rename rpc to interrupt in IPDL error/ unit tests. r=billm
https://hg.mozilla.org/integration/autoland/rev/860dbe58e7f9
part 6 - Fix various IPDL tests. r=billm
https://hg.mozilla.org/integration/autoland/rev/229182531a7f
part 7 - Remove obsolete test. r=billm
You need to log in before you can comment on or make changes to this bug.