1319595 - Fix non-cxx/ IPDL unit tests

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

There are a number of tests in the ipc/ipdl/test/ipdl/ directory that are broken, for various reasons. Clearly nobody has run these in the last few years. I'm going to fix up these tests. Bill also said I could just delete tests relating to the state machine and opens/spawns stuff.

One set of these tests, in error/, have their own special set of problems, because the test suite currently only checks that the test fails, but not why. This has lead to things like a change accidentally dropping a semi-colon, so instead of testing whatever it is supposed to test it is just failing in a syntax error. So we need some kind of expected failure testing. I'll probably put that in a separate bug and just fix up obviously broken things for now.

Comment 1

[Andrew McCreight [:mccr8]]

I have a stack of patches that seems to fix things up locally. I'll make sure it doesn't break anything on try.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=30d1a06f018476d38cf5c0758bb09a7a637f3ca2

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1319595, part 1 - Remove IPDL error tests involving state machine or bridge/open.

Review commit: https://reviewboard.mozilla.org/r/95136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95136/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1319595, part 2 - Add async annotations to IPDL unit tests.

As of bug 1240871 these are no longer optional.

Review commit: https://reviewboard.mozilla.org/r/95138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95138/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1319595, part 3 - Allow including a type twice as long as it is from the same file both times.

This patch fixes multipleUsingCxxTypes.ipdl. This is a regression from
bug 918651.

Review commit: https://reviewboard.mozilla.org/r/95140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95140/

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1319595, part 4 - Fix type checker handling of end points without qualifiers.

If qname has no quals, then fullname would be None, which breaks the
string concatenation in parentEndpointDecl and childEndpointDecl, even
if no endpoints are declared. This patch uses the short name if there
are no quals, while preserving the behavior that we want to pass None
into declare for fullname.

Review commit: https://reviewboard.mozilla.org/r/95142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95142/

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Bug 1319595, part 5 - Rename rpc to interrupt in IPDL error/ unit tests.

Change message annotations from "rpc" to "intr" to match the current
name, and similarly rename the protocols and the files.

Review commit: https://reviewboard.mozilla.org/r/95144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95144/

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: Bug 1319595, part 6 - Fix various IPDL tests.

managerNoCtor.ipdl: Add a message so that parsing doesn't just fail
immediately with a syntax error.

shmem_access_union.ipdl: Remove this test, which involves the
semi-removed ACL feature for shmem.

oldIncludesyntax.ipdl: To be safe, make the protocol more valid by
adding a message.

multimanNonexistentMgrs.ipdl: Make the name of the protocol match the
name of the file.

Review commit: https://reviewboard.mozilla.org/r/95146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95146/

Comment 8

[Andrew McCreight [:mccr8]]

Attachment: Bug 1319595, part 7 - Remove obsolete test.

Bill said it is okay to declare interrupt parent-to-child messages now.

Review commit: https://reviewboard.mozilla.org/r/95148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95148/

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813750 [details]
Bug 1319595, part 1 - Remove IPDL error tests involving state machine or bridge/open.

https://reviewboard.mozilla.org/r/95136/#review96190

Comment 10

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813751 [details]
Bug 1319595, part 2 - Add async annotations to IPDL unit tests.

https://reviewboard.mozilla.org/r/95138/#review96192

Comment 11

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813752 [details]
Bug 1319595, part 3 - Allow including a type twice as long as it is from the same file both times.

https://reviewboard.mozilla.org/r/95140/#review96196

Comment 12

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813753 [details]
Bug 1319595, part 4 - Fix type checker handling of end points without qualifiers.

https://reviewboard.mozilla.org/r/95142/#review96200

Comment 13

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813754 [details]
Bug 1319595, part 5 - Rename rpc to interrupt in IPDL error/ unit tests.

https://reviewboard.mozilla.org/r/95144/#review96202

Comment 14

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813755 [details]
Bug 1319595, part 6 - Fix various IPDL tests.

https://reviewboard.mozilla.org/r/95146/#review96204

Comment 15

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813756 [details]
Bug 1319595, part 7 - Remove obsolete test.

https://reviewboard.mozilla.org/r/95148/#review96206

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a84f47c9a0e0
part 1 - Remove IPDL error tests involving state machine or bridge/open. r=billm
https://hg.mozilla.org/integration/autoland/rev/483bea1e5092
part 2 - Add async annotations to IPDL unit tests. r=billm
https://hg.mozilla.org/integration/autoland/rev/d056bbc15cf8
part 3 - Allow including a type twice as long as it is from the same file both times. r=billm
https://hg.mozilla.org/integration/autoland/rev/86796aaaf1f2
part 4 - Fix type checker handling of end points without qualifiers. r=billm
https://hg.mozilla.org/integration/autoland/rev/967d7be10d7a
part 5 - Rename rpc to interrupt in IPDL error/ unit tests. r=billm
https://hg.mozilla.org/integration/autoland/rev/860dbe58e7f9
part 6 - Fix various IPDL tests. r=billm
https://hg.mozilla.org/integration/autoland/rev/229182531a7f
part 7 - Remove obsolete test. r=billm

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a84f47c9a0e0
https://hg.mozilla.org/mozilla-central/rev/483bea1e5092
https://hg.mozilla.org/mozilla-central/rev/d056bbc15cf8
https://hg.mozilla.org/mozilla-central/rev/86796aaaf1f2
https://hg.mozilla.org/mozilla-central/rev/967d7be10d7a
https://hg.mozilla.org/mozilla-central/rev/860dbe58e7f9
https://hg.mozilla.org/mozilla-central/rev/229182531a7f