Closed Bug 1319604 Opened 3 years ago Closed 3 years ago

cc1plus: warning: unrecognized command line option '-Wno-null-conversion'

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

My eyes just glanced this error message during a build. It turns out we're adding this flag in toolkit/components/protobuf/moz.build, but it's not supported by gcc, only by clang.
Comment on attachment 8813446 [details]
Bug 1319604 - Only add -Wno-null-conversion when building with clang.

https://reviewboard.mozilla.org/r/94834/#review95080

I wonder a) if `-Werror=unknown-warning` works b) how much work it would be to use. I don't like that we may have e.g. typos in warnings that go undetected.

Perhaps we could deal with this another way: have the mach build output monitor capture these messages and report them at the end of the build.
Attachment #8813446 - Flags: review?(gps) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/30297a41cdd1
Only add -Wno-null-conversion when building with clang. r=gps
https://hg.mozilla.org/mozilla-central/rev/30297a41cdd1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.