Closed Bug 1319604 Opened 3 years ago Closed 3 years ago
cc1plus: warning: unrecognized command line option '-Wno-null-conversion'
58 bytes, text/x-review-board-request
My eyes just glanced this error message during a build. It turns out we're adding this flag in toolkit/components/protobuf/moz.build, but it's not supported by gcc, only by clang.
Comment on attachment 8813446 [details] Bug 1319604 - Only add -Wno-null-conversion when building with clang. https://reviewboard.mozilla.org/r/94834/#review95080 I wonder a) if `-Werror=unknown-warning` works b) how much work it would be to use. I don't like that we may have e.g. typos in warnings that go undetected. Perhaps we could deal with this another way: have the mach build output monitor capture these messages and report them at the end of the build.
Attachment #8813446 - Flags: review?(gps) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/30297a41cdd1 Only add -Wno-null-conversion when building with clang. r=gps
You need to log in before you can comment on or make changes to this bug.