IPDL unit tests in error/ should check why the test fails

RESOLVED FIXED in Firefox 55

Status

()

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

As seen in bug 1319595, if we don't check that the reason something failed is correct, then things like renaming of keywords can cause tests to start failing for the wrong reason.
Assignee: nobody → continuation
Depends on: 1347527
Blocks: 1346911
There are two files containing non-annotation changes: ipc/ipdl/test/ipdl/IPDLCompile.py and ipc/ipdl/test/ipdl/runtests.py

The annotations are a little spammy, but they are kind of nice because they are a sort of automatic form of automation.
Err, I meant "automatic form of annotation", though that's still a little redundant.
Comment on attachment 8849210 [details]
Bug 1319620 - Check that IPDL unit tests in error/ fail for the right reason.

https://reviewboard.mozilla.org/r/122036/#review125082
Attachment #8849210 - Flags: review?(wmccloskey) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77b2d0288368
Check that IPDL unit tests in error/ fail for the right reason. r=billm
https://hg.mozilla.org/mozilla-central/rev/77b2d0288368
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.