1319646 - Toggle webrener profiler by preference.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Currently, profiler is disabled by default. Added a preference to control it. The preference would be "gfx.webrender.profiler.enable"

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Add a preference to enable/disable webrender profiler. r=jrmuizel?

MozReview-Commit-ID: 31349AWgDr9

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/2622d62d1f08
Add a preference to enable/disable webrender profiler. r=jrmuizel?

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8813497 [details] [diff] [review]
Add a preference to enable/disable webrender profiler. r=jrmuizel?

Morris, this patch "hides" a change to how we handle all the preferences, it doesn't just add a new preference.  If you need additional functionality in gfxPrefs in the first place, please separate that into a different bug, and let's do a full, pre-landing review.

Or just do a special case for this new preference, keeping it outside the gfxPrefs system, and avoid the changes to it.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Ah, right. I backed out this cset. Will create a dependent bug for gfxPrefs changes.

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Toggle webrender profiler by preferences. r=kats?

MozReview-Commit-ID: DneWqzP34ux

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Toggle webrender profiler by preferences. r=kats?

MozReview-Commit-ID: DneWqzP34ux

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/71c2c806992d
Toggle webrender profiler by preferences. r=kats?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

(In reply to Morris Tseng [:mtseng] [:Morris] from comment #4)
> Ah, right. I backed out this cset. Will create a dependent bug for gfxPrefs
> changes.

This backout was https://hg.mozilla.org/projects/graphics/rev/50f234c53a7a97548a655efd992d04c2792a1954. Please make sure to reference the bug number in backout commit messages so that they're easier to track.