Closed Bug 1319646 Opened 5 years ago Closed 4 years ago

Toggle webrener profiler by preference.

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: mtseng, Assigned: mtseng)

References

Details

Attachments

(1 file, 2 obsolete files)

Currently, profiler is disabled by default. Added a preference to control it. The preference would be "gfx.webrender.profiler.enable"
MozReview-Commit-ID: 31349AWgDr9
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/2622d62d1f08
Add a preference to enable/disable webrender profiler. r=jrmuizel?
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8813497 [details] [diff] [review]
Add a preference to enable/disable webrender profiler. r=jrmuizel?

Morris, this patch "hides" a change to how we handle all the preferences, it doesn't just add a new preference.  If you need additional functionality in gfxPrefs in the first place, please separate that into a different bug, and let's do a full, pre-landing review.

Or just do a special case for this new preference, keeping it outside the gfxPrefs system, and avoid the changes to it.
Flags: needinfo?(mtseng)
Attachment #8813497 - Flags: review-
Ah, right. I backed out this cset. Will create a dependent bug for gfxPrefs changes.
Flags: needinfo?(mtseng)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1319985
MozReview-Commit-ID: DneWqzP34ux
Attachment #8813497 - Attachment is obsolete: true
MozReview-Commit-ID: DneWqzP34ux
Attachment #8813991 - Attachment is obsolete: true
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/71c2c806992d
Toggle webrender profiler by preferences. r=kats?
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
(In reply to Morris Tseng [:mtseng] [:Morris] from comment #4)
> Ah, right. I backed out this cset. Will create a dependent bug for gfxPrefs
> changes.

This backout was https://hg.mozilla.org/projects/graphics/rev/50f234c53a7a97548a655efd992d04c2792a1954. Please make sure to reference the bug number in backout commit messages so that they're easier to track.
Target Milestone: --- → mozilla54
Depends on: 1370977
You need to log in before you can comment on or make changes to this bug.