Correct webkit-text-stoke and webkit-text-fill-color pages on MDN

RESOLVED FIXED

Status

Developer Documentation
CSS
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jeremychen, Assigned: jeremychen)

Tracking

Details

(URL)

Attachments

(1 attachment)

According to the spec. (https://compat.spec.whatwg.org/#the-webkit-text-stroke-color), the initial value of -webkit-text-stroke-color is currentcolor, not rgb(0, 0, 0). We implemented -webkit-text-stroke-color accordingly in Bug 1248708.

I'd like to fix this by myself, but I only see {{cssinfo}} in the editing page... :-/
Hi Sebastian, is there any way that I can contribute to MDN in this case? If so, please guide me, so I could just fix it without filing a bug.
Flags: needinfo?(sebastianzartner)
Looks like https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-text-stroke-width has a bit wrong as well. The computed value in the spec. (https://compat.spec.whatwg.org/#the-webkit-text-stroke-width) is "absolute width", however, the computed value specified on MDN is "as specified".

I think the MDN page of -webkit-text-stroke (https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-text-stroke) should be corrected as well.
Summary: Initial value of -webkit-text-stroke-color on MDN is wrong → Correct -webkit-text-stroke related pages on MDN

Updated

2 years ago
Keywords: dev-doc-needed
Priority: -- → P3
(In reply to Jeremy Chen [:jeremychen] UTC+8 from comment #1)
> Hi Sebastian, is there any way that I can contribute to MDN in this case? If
> so, please guide me, so I could just fix it without filing a bug.

Hi Jeremy, thank you for filing the issue!
The CSS data is maintained on GitHub, see https://github.com/mdn/data/blob/master/css/properties.json.
So, to contribute, please provide a pull request.

Astley, thank you for adding the 'dev-doc-needed' keyword, though for bugs in the Developer Documentation product it is redundant.

Sebastian
Flags: needinfo?(sebastianzartner)
Keywords: dev-doc-needed
Created attachment 8813924 [details]
PR to MDN's CSS data

1. Check the spec. and fix webkit-text-stroke and webkit-text-fill-color.
2. Correct all 'currentcolor' to 'currentColor'.
Assignee: nobody → jeremychen
Status: NEW → ASSIGNED
Comment on attachment 8813924 [details]
PR to MDN's CSS data

I'll close this bug once the PR is merged.
Flags: needinfo?(jeremychen)
Attachment #8813924 - Flags: review?(sebastianzartner)
Comment on attachment 8813924 [details]
PR to MDN's CSS data

See my review at https://github.com/mdn/data/pull/22#pullrequestreview-10096955.

Sebastian
Attachment #8813924 - Flags: review?(sebastianzartner) → review-
Comment on attachment 8813924 [details]
PR to MDN's CSS data

PR is updated, re-request review.
Flags: needinfo?(jeremychen)
Attachment #8813924 - Flags: review- → review?(sebastianzartner)
Sorry for the delay! Most of the things are fixed. Thank you for that!
There is one last issue I commented on here:
https://github.com/mdn/data/pull/22/commits/a17aaf9836c911ec4d6cdfef3eb6b91986a5ea02#r89679814

Sebastian
Comment on attachment 8813924 [details]
PR to MDN's CSS data

The last issue still needs to be fixed, so I mark this with r-.
With that issue fixed I'll mark this r+.

Sebastian
Attachment #8813924 - Flags: review?(sebastianzartner) → review-
Comment on attachment 8813924 [details]
PR to MDN's CSS data

PR is updated, re-request review.
Attachment #8813924 - Flags: review- → review?(sebastianzartner)
Summary: Correct -webkit-text-stroke related pages on MDN → Correct webkit-text-stoke and webkit-text-fill-color pages on MDN
Comment on attachment 8813924 [details]
PR to MDN's CSS data

I've merged your patch. Thank you for the contribution!

As I wrote in https://github.com/mdn/data/commit/d9862d0569aa874c29d61d78ea75cebc6f39aa87#commitcomment-19973153, there's a follow-up thing to do. So, could you please create a new PR for that?

Sebastian
Attachment #8813924 - Flags: review?(sebastianzartner) → review+
Flags: needinfo?(jeremychen)
Sure, I just sent the PR, please check.
Flags: needinfo?(jeremychen)
Perfect! Thank you! That was a good teamwork! :-)

Sebastian
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(In reply to Sebastian Zartner [:sebo] from comment #13)
> Perfect! Thank you! That was a good teamwork! :-)
> 
> Sebastian

Thank you for the review and guidance. Glad that I can help. :-)
You need to log in before you can comment on or make changes to this bug.