Closed Bug 1319703 Opened 3 years ago Closed 3 years ago

Convert some code in extensions/ to C++11

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(2 files)

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators
QA Contact: bpostelnicu
Attachment #8813572 - Flags: review?(jduell.mcbugs)
Attachment #8813573 - Flags: review?(jduell.mcbugs)
Assignee: nobody → bpostelnicu
QA Contact: bpostelnicu
Attachment #8813572 - Flags: review?(jduell.mcbugs) → review+
Attachment #8813573 - Flags: review?(jduell.mcbugs) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/467e719c9e9a
Replace default bodies of special member functions with = default; in extensions/. r=jduell
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1f5a73d1a47
Use C++11's override and remove virtual where applicable in extensions/. r=jduell
https://hg.mozilla.org/mozilla-central/rev/467e719c9e9a
https://hg.mozilla.org/mozilla-central/rev/c1f5a73d1a47
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.