Closed Bug 1319705 Opened 7 years ago Closed 7 years ago

Move Puppeteer to testing/marionette and make it available for Marionette tests in test packages

Categories

(Remote Protocol :: Marionette, defect)

Version 3
defect
Not set
normal

Tracking

(firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

To allow Marionette tests to optionally use the Firefox Puppeteer package we will have to get it installed for mach and mozharness.
As it turns out there is no need to add the extra dependency to the mach command for marionette-test, given that mach_bootstrap automatically finds it when running any kind of tests. So the only place we actually have to add the dependency would be in the configuration files of mozharness to get a working environment.
Comment on attachment 8813663 [details]
Bug 1319705 - Move Puppeteer to testing/marionette and make it available for Marionette tests in test packages.

https://reviewboard.mozilla.org/r/95076/#review95276
Attachment #8813663 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6beaa787043
Add firefox_puppeteer as dependency for Marionette in test archive. r=maja_zf
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/e1b2579a01f3
Backed out changeset b6beaa787043 for marionette mass bustage. r=backout on a CLOSED TREE
The problem here is that there is no extracted puppeteer folder because all the other test harnesses which are requiring Marionette specify a minimum set of directories to extract which includes marionette from common.tests.zip:

https://dxr.mozilla.org/mozilla-central/search?q=minimum_tests_zip_dirs&=mozilla-central

I'm not really inclined to add puppeteer to those lists, so the question is if we could go ahead and move puppeteer into testing/marionette/puppeteer. Reason here is that Puppeteer is coupled to Marionette and cannot be used by any other test harness.

With that we can include it under marionette/ in the common.tests.zip package, which will automatically be extracted via the current minimum_tests_zip_dirs settings.

David, would you be ok with that change?
Flags: needinfo?(dburns)
Seems fine to me.
Flags: needinfo?(dburns)
Summary: Install Firefox Puppeteer package for Marionette (mach / mozharness) → Move Puppeteer to testing/marionette and make it available for Marionette tests in test packages
Depends on: 1310632
Blocks: 1316984
Whiteboard: [needs update readthedocs]
The move of files as covered by this bug will only include the Puppeteer core files, but not the Puppeteer tests. This is still blocked on being able to specify custom server root paths and will be covered in a follow-up bug. Until then the Puppeteer tests will still be run via firefox-ui-functional jobs.
Attachment #8813663 - Flags: review?(gps)
The last try push fixed the mass-bustage for all the other test harnesses, but caused a failure for Marionette due to the change of the harness from `marionette/` to `marionette/harness`.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e757971eccfe

I will push a follow-up commit which fixes this and retrigger only Marionette tests.
Attachment #8813663 - Attachment is obsolete: true
Attachment #8814160 - Flags: review?(gps)
Keywords: leave-open
Comment on attachment 8814160 [details]
Bug 1319705 - Move Puppeteer to testing/marionette and make it available for Marionette tests in test packages.

https://reviewboard.mozilla.org/r/95428/#review96530

Seems reasonable.
Attachment #8814160 - Flags: review?(gps) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7eab0a7c766e
Move Puppeteer to testing/marionette and make it available for Marionette tests in test packages. r=gps
Readthedocs links have been updated. So builds are passing again.

We also want this patch as part of the next ESR release. So please uplift to aurora. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [needs update readthedocs] → [checkin-needed-aurora]
Target Milestone: --- → mozilla53
https://hg.mozilla.org/releases/mozilla-aurora/rev/30088f155be0
Flags: in-testsuite+
Whiteboard: [checkin-needed-aurora]
Depends on: 1321625
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.