Open Bug 1319725 Opened 5 years ago Updated 3 months ago
Rework the test
The test_reactivate.html tests the scenario that invoking play() operation on a no-longer-referenced video element keeps it alive. The play() operation neither work immediately nor fail; it marks the video element as "someone is expecting events from it" so that we should make the video element alive. However, once the bug 1244768 is completed, invoking a play() operation on a no-longer-referenced video element should fail immediately because we're not able to get the global object of the video element so that we cannot create a DOM promise for the play() operation. The original scenario is still valid for seek operation or autoplay mechanism. I will modify the test case to use autoplay mechanism since the W3C is considering modify the seek operation to return a promise, just like the play() operation now.
The test_reactivate.html itself does not do what it claims. The `reviveElement()` callback captures the video element and the `reviveElement()` is set to a timer, so the video element won't be GCed. Disable this test case now for implementing bug 1244768 and will rework this test case later.
Comment on attachment 8813926 [details] Bug 1319725 - disable the test_reactivate.html; https://reviewboard.mozilla.org/r/95228/#review95484
Attachment #8813926 - Flags: review?(jwwang) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/03434938bd29 disable the test_reactivate.html; r=jwwang
4 years ago
Priority: -- → P3
Assignee: kakukogou → alwu
You need to log in before you can comment on or make changes to this bug.