1319732 - Side by side add-on installation pop-ups

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Vasilica Tamas, QA [:vtamas]]

[Affected versions]:
Firefox 53.0a1 (2016-11-22)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Navigate to https://addons.mozilla.org
3.Choose an add-on and click on “+ Add to Firefox” green button. 
4.Complete the installation process by clicking on “Install” button from doorhanger.
5.While the confirmation doorhanger is still displayed, choose another add-on and click on “+ Add to Firefox” green button.


[Expected Results]:
The second add-on doorhanger appears under the first one. 


[Actual Results]:
- The doorhangers are displayed one next each other.
- UI issues: http://screencast.com/t/qTqmPh6zZyOK

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Old multiple popups

Philipp, can you please check that the old behavior (see screenshot) is still something we want to do for the new doorhanger design? Meaning should we still stack them on top of each other like before or is there some other concept we could use?

Comment 3

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Redirecting this to Markus as per our conversation at the all hands

Comment 4

[Markus Jaritz [:markus] (UX)]

I see that they currently stack on top of each other with the download appearing on the right side if it. It would be great if we would stack all on top of each other - including download indicator, but have the most recent install confirmation be on top.

Side note: Our next iteration on the install flow plans to have the install confirmation to be modal so as to not enable multiple installs in parallel but require a decision on whether or not to install an extension before continue using the site.

Comment 5

[Johann Hofmann [:johannh]]

Attachment: Bug 1319732 - Stack popupnotifications vertically.

Review commit: https://reviewboard.mozilla.org/r/101186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101186/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8822202 [details]
Bug 1319732 - Stack popupnotifications vertically.

Can we fix bug 1320314 instead? See my proposal in bug 1320314 comment 3.

Comment 7

[Johann Hofmann [:johannh]]

Maybe my brain is failing to correctly apply the proposed CSS in bug 1320314 comment 3, would that solve the problem at hand here?

Or did you mean we should fix bug 1320314 before fixing this one?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #7)
> Maybe my brain is failing to correctly apply the proposed CSS in bug 1320314
> comment 3, would that solve the problem at hand here?

It would allow us to get rid of both overflow and the problematic display:block if this comment is to be believed:

   * by hiding the overflow, and we have to override the "display" property so
   * that the height of the contents is computed correctly in that case. */

> Or did you mean we should fix bug 1320314 before fixing this one?

That too, the code doesn't belong in this file.

Comment 9

[:Paolo Amadini]

As I also noted in bug 1320314, the need to avoid "display: -moz-box;" is likely related to bug 1293242 so it will be unneeded once that is fixed.

Comment 10

[Johann Hofmann [:johannh]]

Comment on attachment 8822202 [details]
Bug 1319732 - Stack popupnotifications vertically.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101186/diff/1-2/

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 8822202 [details]
Bug 1319732 - Stack popupnotifications vertically.

https://reviewboard.mozilla.org/r/101186/#review103810

Comment 12

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=528cf99edae4

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7c9a456f7a1
Stack popupnotifications vertically. r=dao

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7c9a456f7a1

Comment 15

[Md.Tarikul Islam Oashi]

I have to reproduced this bug with Nightly 53.0a1 (2016-11-22) on Windows 7 64 bit;

The Bug's fix is verified on beta

Build ID 	20170111030235
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

[Bugday-20170111]

Comment 16

[Mohammad Maruf Rahman]

I have reproduced this bug with  Nightly 53.0a1 (2016-11-23) on Ubuntu 16.04 LTS , 64 Bit !

This bug's fix is verified with latest Nightly 

Build   ID   20170111030235
User Agent   Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
[bugday-20170111]

Comment 17

[Johann Hofmann [:johannh]]

Thanks!

Comment 18

[Brindusa Tot, Desktop QA]

Based on comment 16, mark bug verified on firefox 53.