Closed Bug 1319788 Opened 3 years ago Closed 3 years ago

Telemetry for number of imported items is broken

Categories

(Firefox :: Migration, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

(In reply to :Gijs Kruitbosch from bug 1279501 comment #20)
> I am an idiot.
> 
> >           let histogram = Services.telemetry.getKeyedHistogram(histogramId);
> 
> should be getKeyedHistogramById
> 
> Also bug 1311100's fixes can't come soon enough.
> 
> I'll file a dep to get this fixed and uplifted ASAP.
Comment on attachment 8813683 [details]
Bug 1319788 - fix typo in getting a telemetry histogram,

https://reviewboard.mozilla.org/r/95092/#review95248
Attachment #8813683 - Flags: review?(mak77) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/630e0a8c3241
fix typo in getting a telemetry histogram, r=mak
Comment on attachment 8813683 [details]
Bug 1319788 - fix typo in getting a telemetry histogram,

Approval Request Comment
[Feature/regressing bug #]: bug 1279501
[User impact if declined]: no telemetry, no decisions, bad for users
[Describe test coverage new/current, TreeHerder]: no, because telemetry. We'll know it works when telemetry comes in (also, I tested it locally, for whatever that means).
[Risks and why]: none - it was broken and not actually breaking anything (besides the telemetry) because of the try catch. This can only make things better, not worse.
[String/UUID change made/needed]: nope
Attachment #8813683 - Flags: approval-mozilla-beta?
Attachment #8813683 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/630e0a8c3241
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment on attachment 8813683 [details]
Bug 1319788 - fix typo in getting a telemetry histogram,

Fix a typo error in telemetry. Beta51+ and Aurora52+. Should be in 51 beta 3.
Attachment #8813683 - Flags: approval-mozilla-beta?
Attachment #8813683 - Flags: approval-mozilla-beta+
Attachment #8813683 - Flags: approval-mozilla-aurora?
Attachment #8813683 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.