Telemetry for number of imported items is broken

RESOLVED FIXED in Firefox 51

Status

()

Firefox
Migration
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox51 fixed, firefox52 fixed, firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
(In reply to :Gijs Kruitbosch from bug 1279501 comment #20)
> I am an idiot.
> 
> >           let histogram = Services.telemetry.getKeyedHistogram(histogramId);
> 
> should be getKeyedHistogramById
> 
> Also bug 1311100's fixes can't come soon enough.
> 
> I'll file a dep to get this fixed and uplifted ASAP.
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8813683 [details]
Bug 1319788 - fix typo in getting a telemetry histogram,

https://reviewboard.mozilla.org/r/95092/#review95248
Attachment #8813683 - Flags: review?(mak77) → review+

Comment 3

a year ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/630e0a8c3241
fix typo in getting a telemetry histogram, r=mak
(Assignee)

Updated

a year ago
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox53: --- → affected
(Assignee)

Comment 4

a year ago
Comment on attachment 8813683 [details]
Bug 1319788 - fix typo in getting a telemetry histogram,

Approval Request Comment
[Feature/regressing bug #]: bug 1279501
[User impact if declined]: no telemetry, no decisions, bad for users
[Describe test coverage new/current, TreeHerder]: no, because telemetry. We'll know it works when telemetry comes in (also, I tested it locally, for whatever that means).
[Risks and why]: none - it was broken and not actually breaking anything (besides the telemetry) because of the try catch. This can only make things better, not worse.
[String/UUID change made/needed]: nope
Attachment #8813683 - Flags: approval-mozilla-beta?
Attachment #8813683 - Flags: approval-mozilla-aurora?

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/630e0a8c3241
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment on attachment 8813683 [details]
Bug 1319788 - fix typo in getting a telemetry histogram,

Fix a typo error in telemetry. Beta51+ and Aurora52+. Should be in 51 beta 3.
Attachment #8813683 - Flags: approval-mozilla-beta?
Attachment #8813683 - Flags: approval-mozilla-beta+
Attachment #8813683 - Flags: approval-mozilla-aurora?
Attachment #8813683 - Flags: approval-mozilla-aurora+

Comment 7

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/7f611a717df6
status-firefox52: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/482eefb7b7a75d450af08c4537ff17515fd8871c
status-firefox51: affected → fixed
You need to log in before you can comment on or make changes to this bug.