1319790 - Crash in mozilla::MediaDecoder::NotifyBytesDownloaded

Status: RESOLVED DUPLICATE of bug 1332544

(Core :: Audio/Video: Playback, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-710daa98-0d80-427c-a71f-499ae2161122.
=============================================================

Seen while looking at Nightly Crash stats: http://bit.ly/2gB6m9E. Started with 20161122030216 build. Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b7f895c1dc2e91530240efbf50ac063a0f8a9cb5&tochange=0534254e9a40b4bade2577c631fe4cfa0b5db41d

Not sure if Bug 1309516 has anything to do with the crash. ni on kaku

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1319790 - add assertions to detect if MediaDecoder is deleted without Shutdown() being called.

Also call mResourceCallback->Disconnect() in the destructor in case Shutdown() is not called to avoid dangling pointer.

Review commit: https://reviewboard.mozilla.org/r/95272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95272/

Comment 2

[Tzuhao Kuo [:kaku]]

Comment on attachment 8813967 [details]
Bug 1319790 - add assertions to detect if MediaDecoder is deleted without Shutdown() being called.

https://reviewboard.mozilla.org/r/95272/#review95450

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65643222e76c
add assertions to detect if MediaDecoder is deleted without Shutdown() being called. r=kaku

Comment 5

[Tzuhao Kuo [:kaku]]

Bug 1309516 is unlikely related to this issue, however, will keep an eye on this.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/65643222e76c

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Bug 1332544 should've fixed this.

Comment 8

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.