You can check this fiddle: https://jsfiddle.net/tabhtu61/3/
Regression range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=067521 ccd17907843e1db644ca0f02a1f5a6520a&tochange=eac0c056235ee1174fc092fe159d2d571033 1fbd Matt Woodrow — Bug 1283827 - Flatten transform-style:preserve-3d when combined with opacity. r=dbaron Matt, could you check if it's normal that's the event is not fired after the spec change in bug 1283827.
Component: Untriaged → Layout
OS: Unspecified → All
Product: Firefox → Core
Hardware: Unspecified → All
status-firefox50: --- → wontfix
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox53: --- → affected
tracking-firefox51: --- → ?
tracking-firefox52: --- → ?
tracking-firefox53: --- → ?
Too late for 51, but we can still take patches for 52/53.
status-firefox51: affected → fix-optional
status-firefox52: affected → fix-optional
tracking-firefox51: ? → -
tracking-firefox52: ? → -
tracking-firefox53: ? → +
Created attachment 8825596 [details] [diff] [review] Update overflow areas when opacity toggles Having the opacity property disables preserve-3d (making that change was what regressed this). Preserve-3d frames do crazy things with overflow areas, so when we transition in/out of having opacity, we need to make sure we recompute the overflow areas. Are you ok with reviewing this Timothy? Dbaron isn't accepting review requests at the moment.
Assignee: nobody → matt.woodrow
Attachment #8825596 - Flags: review?(tnikkel)
Attachment #8825596 - Flags: review?(tnikkel) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/38a92c2df699 Update the overflow areas of all descendants when we toggle opacity on a preserve-3d frame. r=tnikkel
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3d13ed042963 followup, fix rebasing oops
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Please request Aurora/Beta approval on this when you get a chance.
status-firefox51: fix-optional → wontfix
Comment on attachment 8825596 [details] [diff] [review] Update overflow areas when opacity toggles Approval Request Comment [Feature/Bug causing the regression]: Bug 1283827 [User impact if declined]: Invalid rendering when dynamically toggling opacity in the presence of preserve-3d, relatively rare. [Is this code covered by automated tests?]: Yes, new reftest added. [Has the fix been verified in Nightly?]: [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: Just this patch [Is the change risky?]: No [Why is the change risky/not risky?]: Just increases the work when we do when we detect an opacity style change. It should never be dangerous to do more than necessary. [String changes made/needed]: None
Hi Brindusa, Could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!
Verified as fixed on 54.0a1 20170215110151 on Ubuntu 16.04 x64, Windows 10 x64, OSX 10.10.
status-firefox54: fixed → verified
Comment on attachment 8825596 [details] [diff] [review] Update overflow areas when opacity toggles Fix a rendering issue when dynamically toggling opacity in the presence of preserve-3d. Aurora53+.
Attachment #8825596 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8825596 [details] [diff] [review] Update overflow areas when opacity toggles fix opacity vs preserve-3d interaction, beta52+
Attachment #8825596 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Matt, seems this still hit conflicts in layout/reftests/transform-3d/reftest.list for aurora could you take a look, thanks!
status-firefox53: affected → fixed
status-firefox52: fix-optional → fixed
status-firefox-esr52: --- → fixed
You need to log in before you can comment on or make changes to this bug.