1319834 - Find in page does not highlight results cotaining both hyperlink and normal text

Status: NEW

(Firefox for iOS :: General, defect, P3)

Description

[Simon Basca [:SimonB]]

Build: 6.0b4
Device: iPad Pro 
iOS: 9.3.5

Steps to reproduce:
1. Go to https://en.wikipedia.org/wiki/Wiki
2. Open the menu 
3. Tap Find in page
4. Type 'using wiki software'

Actual result:
- The words are not found in the page and do not appear highlighted. When typing only words that contain a hyperlink, they are found and highlighted. When typing combine words that contain/don't contain a link, they are not not found in page and do not appear highlighted. 

Expected results:
- The words should be found and highlighted. 

Note:
- The same issue is not reproducible in Safari.

See video of the issue: 
https://www.youtube.com/watch?v=Dwpif4YCsLA

Comment 1

[Erica Wright [:ewright]]

I looked into this a bit and found it is because we are inserting a span element into the page for each found result. We cannot wrap the span element across elements, so we don't search across them. This strategy opens up problems if there is specific styling on the page that applies to spans. Safari seems to use an overlay of sorts, as do we on desktop, perhaps we should consider that type of strategy instead, though it would be a fairly large overhaul.