1319836 - Theme property names are confusing and don't apply as the user may expect

Status: RESOLVED INVALID

(WebExtensions :: Themes, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

In the colors section, we have the following properties:

"background_tab": This color sets the background-color of the selected tab (currently only tab-middle though that appears to be a separate bug). The actual displayed color is lighter than the requested color.

"background_tab_inactive": This color right now only sets the tab-overflow button background-color. It would seem that this should set the background-color when an unselected tab is hovered.

"background_tab_text": This color doesn't seem to apply anywhere, though it would seem that it should set the color of the text in the tabs.

"button_background": This color doesn't seem to apply anywhere, though it would seem that it should set the background color of buttons in the toolbars when not hovered or active.

"frame": This sets the color of the navigation-toolbar and tabs toolbar. Though the navigation toolbar gets a lighter version of it.

"frame_inactive": This color should set the navigation-toolbar and tabs toolbar when the window is unfocused, though it actually sets the color of the navigation-toolbar. The value used for "frame_inactive" is the actual displayed color, unlike the "frame" property above.

"tab_text": This color only applies to the selected tab's text. I expected it to apply to all tabs.

"toolbar": This color seems to only apply to the tab overflow buttons. I expected it to set the background color of all toolbars.

"toolbar_bottom_separator": I don't see where this is applying. I expected it to be the color of the horizontal separator between the navigation toolbar and the page content.

"toolbar_button_stroke": This color is used when a toolbar button is pressed.

"toolbar_button_stroke_inactive": This color is used when a toolbar button is hovered.

"toolbar_input_control": This sets the background-color of the location bar and search bar.

"toolbar_input_control_stroke": This sets the border of the location bar and search bar.

"toolbar_top_separator": I don't see where this color is used, though I expected it to be used between the navigation toolbar and tabs toolbar.

"toolbar_vertical_selector": This is used in the location bar as the color of the separator between the identity block and the location, as well as between the location and the urlbar-controls (stop/reload).

"ntp_background": This sets the background color of the new tab page as well as the home page. This is working as expected.

"ntp_text": This sets the color of the text in the search box on both the new tab page and home page. I expected it to affect other text within the page.

"ntp_link": I didn't see where this color gets applied, though I suspect it is used for links within snippets and I couldn't get a snippet to appear that included a link.

"ntp_link_underline": I didn't see where this color gets applied, though I suspect it is used for the underlined color of links within snippets and I couldn't get a snippet to appear that included a link.

"ntp_header": This color is used for the text of the buttons on the home page. I expected it to change some top portion of the new tab page and home page.

"ntp_section": I didn't see where this color gets applied, though I expected it to apply to the background of the bottom portion of the new tab tiles.

"ntp_section_text": I didn't see where this color gets applied, though I expected it to apply to the color of the text in the bottom portion of the new tab tiles.

"ntp_section_link": I didn't see where this color gets applied, and I'm not sure where it would apply.

"ntp_section_link_underline": I didn't see where this color gets applied, and I'm not sure where it would apply.

Comment 1

[Andrew Swan [:aswan]]

mass move of existing themes bugs to new WebExtensions: Themes component

Comment 2

[Tim Nguyen :ntim]

no longer relevant.