[Wayland/HiDPI] Draw hi-res GTK widgets on HiDPI screens
Categories
(Core :: Widget: Gtk, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: cassidy, Assigned: stransky)
References
Details
(Whiteboard: tpi:+)
Attachments
(2 files)
Comment 1•8 years ago
|
||
Updated•8 years ago
|
![]() |
||
Updated•8 years ago
|
Assignee | ||
Comment 2•7 years ago
|
||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Assignee | ||
Comment 14•6 years ago
|
||
I did some investigation/debugging here and it looks like only the scale is actually correct. What is wrong is the icons rendered as check/radio indicator. Frame around the check is correct as well as buttons/combo boxes for instance.
Assignee | ||
Comment 15•6 years ago
|
||
Looks like gtk_style_context_set_scale() is only half of the solution. Looks like a combination of missing style scale and malformed -gtk-scaled() icon rendering.
Assignee | ||
Comment 16•6 years ago
|
||
Call gtk_style_context_set_scale() on styles created by WidgetStyleCache module on Gtk 3.20+
Also modify moz_gtk_widget_paint_* routines to pass the scale info to CreateStyleContext()
from WidgetStyleCache.
Assignee | ||
Comment 17•6 years ago
|
||
When we draw on HiDPI display on Linux we scale the widget. On Wayland/HiDPI displays allow to set cairo_surface_set_device_scale() to draw
hi-res widgets by moz_gtk_widget_paint().
Depends on D28466
Assignee | ||
Comment 18•6 years ago
|
||
The patches here are for Wayland only, I don't have appropriate hardware to text X11 HiDPI. Filed Bug 1546343 for it. It should be easy to extend this patch to X11 systems but has to be tested on real HiDPI display on X11.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 19•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 20•6 years ago
|
||
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82d825105204
[Linux/HiDPI] Set scale factor on styles created at WidgetStyleCache, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/683bd799a54c
[Linux/Wayland/HiDPI] Use cairo_surface_set_device_scale() on HiDPI displays, r=lsalzman
Comment 21•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/82d825105204
https://hg.mozilla.org/mozilla-central/rev/683bd799a54c
Description
•