Fix broken paths reported by the test in bug 1316187

RESOLVED FIXED in Firefox 53

Status

()

Firefox
General
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: florian, Assigned: florian)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
The test I'm working on in bug 1316187 reports at the end as info() a list of urls that have been found in our code but don't point to actual files. That part of the output is noisy, but these 3 lines seem to point at straightforward to fix real problems in our code:

INFO - missing file with code reference: chrome://global/content/bindings/videoControls.xml
INFO - missing file with code reference: resource://gre/modules/ConsoleAPIStorage.jsm
INFO - missing file with code reference: resource://gre/modules/RecentWindow.jsm
(Assignee)

Comment 1

11 months ago
Created attachment 8813757 [details] [diff] [review]
Patch

At first I fixed "resource://gre/modules/RecentWindow.jsm" by replacing it with "resource:///modules/RecentWindow.jsm", but RecentWindow doesn't seem to ever be used here. Then I noticed set/clearInterval aren't used either, and this removes the last use of XPCOMUtils there.
Attachment #8813757 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Updated

11 months ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8813757 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 2

11 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b05c8f63d8a2bbcbc95c40cb462f80d4a962be2d
Bug 1319844 - Fix a few broken paths, r=Gijs.

Comment 3

11 months ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/030a4cd9e71f
Backed out changeset b05c8f63d8a2

Comment 4

11 months ago
backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=670ad168fb708a7eca83480419f6206833b2566e because of continued test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39930510&repo=mozilla-inbound

maybe this need a try run to find out what was going wrong
Flags: needinfo?(florian)
(Assignee)

Comment 5

11 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c7b942f915b4ba43119f17d735c75c6b7376e32
Bug 1319844 - Fix a few broken paths, r=Gijs.
(Assignee)

Updated

11 months ago
Flags: needinfo?(florian)

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7c7b942f915b
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.