Closed Bug 1319844 Opened 3 years ago Closed 3 years ago

Fix broken paths reported by the test in bug 1316187

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

The test I'm working on in bug 1316187 reports at the end as info() a list of urls that have been found in our code but don't point to actual files. That part of the output is noisy, but these 3 lines seem to point at straightforward to fix real problems in our code:

INFO - missing file with code reference: chrome://global/content/bindings/videoControls.xml
INFO - missing file with code reference: resource://gre/modules/ConsoleAPIStorage.jsm
INFO - missing file with code reference: resource://gre/modules/RecentWindow.jsm
Attached patch PatchSplinter Review
At first I fixed "resource://gre/modules/RecentWindow.jsm" by replacing it with "resource:///modules/RecentWindow.jsm", but RecentWindow doesn't seem to ever be used here. Then I noticed set/clearInterval aren't used either, and this removes the last use of XPCOMUtils there.
Attachment #8813757 - Flags: review?(gijskruitbosch+bugs)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8813757 - Flags: review?(gijskruitbosch+bugs) → review+
backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=670ad168fb708a7eca83480419f6206833b2566e because of continued test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39930510&repo=mozilla-inbound

maybe this need a try run to find out what was going wrong
Flags: needinfo?(florian)
Flags: needinfo?(florian)
https://hg.mozilla.org/mozilla-central/rev/7c7b942f915b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.