1319844 - Fix broken paths reported by the test in bug 1316187

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Florian Quèze [:florian]]

The test I'm working on in bug 1316187 reports at the end as info() a list of urls that have been found in our code but don't point to actual files. That part of the output is noisy, but these 3 lines seem to point at straightforward to fix real problems in our code:

INFO - missing file with code reference: chrome://global/content/bindings/videoControls.xml
INFO - missing file with code reference: resource://gre/modules/ConsoleAPIStorage.jsm
INFO - missing file with code reference: resource://gre/modules/RecentWindow.jsm

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

At first I fixed "resource://gre/modules/RecentWindow.jsm" by replacing it with "resource:///modules/RecentWindow.jsm", but RecentWindow doesn't seem to ever be used here. Then I noticed set/clearInterval aren't used either, and this removes the last use of XPCOMUtils there.

Comment 2

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b05c8f63d8a2bbcbc95c40cb462f80d4a962be2d
Bug 1319844 - Fix a few broken paths, r=Gijs.

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/030a4cd9e71f
Backed out changeset b05c8f63d8a2

Comment 4

[Carsten Book [:Tomcat]]

backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=670ad168fb708a7eca83480419f6206833b2566e because of continued test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39930510&repo=mozilla-inbound

maybe this need a try run to find out what was going wrong

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c7b942f915b4ba43119f17d735c75c6b7376e32
Bug 1319844 - Fix a few broken paths, r=Gijs.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7c7b942f915b