1319847 - [traceback] TypeError: write() argument must be str, not bytes [antenna]

Status: RESOLVED FIXED

(Socorro :: Antenna, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sentry email:

"""
TypeError: write() argument must be str, not bytes
(4 additional frame(s) were not displayed)
...
  File "antenna/metrics.py", line 235, in _timer_decorator
    return fun(*args, **kwargs)
  File "antenna/breakpad_resource.py", line 230, in on_post
    raw_crash, dumps = self.extract_payload(req)
  File "antenna/breakpad_resource.py", line 140, in extract_payload
    fs = cgi.FieldStorage(fp=data, environ=req.env, keep_blank_values=1)
"""

https://sentry.prod.mozaws.net/operations/antenna-stage/issues/369563/

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Looks like the incoming payload is compressed, but not marked as such. We should add handling for that situation.

Also, we should add a section to the spec about what a compressed payload looks like HTTP-wise. Probably in this section: http://antenna.readthedocs.io/en/latest/spec_v1.html#crash-reports-and-the-current-collector

Making this block Antenna tracker and grabbing it to work on Monday.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I can't reproduce this. It's entirely possible that the changes I made earlier today alleviate this problem.

I'm going to mark it as FIXED and move forward. If it's still a problem, we can reopen.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Switching Antenna bugs to Antenna component.