1319902 - Various Xpcshell test failures on XP only: dom/push/test/xpcshell/test_register_success_http2.js, netwerk/test/unit/test_immutable.js, etc.

Status: RESOLVED WONTFIX

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_register_success_http2.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_register_error_http2.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_unregister_success_http2.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_notification_http2.js | xpcshell return code: 0 
TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_registration_success_http2.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_immutable.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_immutable.js | run_test - [run_test : 14] "" != ""
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http2.js | xpcshell return code: 0 
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http2.js | testOnStopRequest - [testOnStopRequest : 80] false == true
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_altsvc.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_altsvc.js | run_test - [run_test : 29] "" != ""

Last good:
Tue Nov 22, 2016, 14:46:34:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=6298ffcae715b3b37a885ddc74eaf01bd7240293
M-C: 0534254e9a40b4bade2577c631fe4cfa0b5db41d

First bad:
Tue Nov 22, 2016, 20:17:49
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=a26cd7d8d5343484461ecac950baffa9da9936ac
M-C: 1a3194836cb4

Range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0534254e9a40b4bade2577c631fe4cfa0b5db41d&tochange=1a3194836cb4

That wouldn't have anything to do with bug 1305453? Aleth, can you please take a look.

Comment 1

[Jorg K (CEST = GMT+2)]

Hmm, this looks suspicious:

INFO -  Error: Invalid port in MOZHTTP2_PORT env var:  at C:/slave/test/build/tests/xpcshell/tests/dom/push/test/xpcshell/head-http2.js:7

Most of the failing tests use this:
https://dxr.mozilla.org/mozilla-central/search?q=MOZHTTP2_PORT&redirect=false

Let's see whether anyone knows anything here, but who to ask? Those tests haven't changed, so has something in the XP environment changed?

Comment 2

[Jorg K (CEST = GMT+2)]

Chris, I don't know who to ask. We suddenly see Xpcshell test failures on XP only related to an environment variable. It's hard to imagine why those unchanged tests fail on XP and not Win7 unless something changed in the setup of those machines.

If you're the wrong person to ask, can you forward it to the right person.

Comment 3

[aleth [:aleth]]

It was being discussed to drop Firefox support for XP and Vista from 53 onwards, so this may just be the first fallout from that.  In that case, the right thing to do would be to stop running c-c tests on XP. I don't see any Firefox tests running on XP any more.

Comment 4

[aleth [:aleth]]

See bug 1130266. I will take care of disabling the tests in a separate bug.

Comment 5

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #4)
> See bug 1130266. I will take care of disabling the tests in a separate bug.

Filed Bug 1319942. That shouldn't be taken to mean this bug doesn't need confirming. It's possible Firefox disabled the tests for reasons that don't yet apply to Thunderbird.

Comment 6

[Jorg K (CEST = GMT+2)]

Right, I still want to know why tests are failing.

Comment 7

[Masatoshi Kimura [:emk]]

We intentionally broke those tests on XP. See bug 1310855.

Comment 8

[Jorg K (CEST = GMT+2)]

So according to bug 1310855 comment #10
  Re-landed, as we do appear to not be testing anything on xp any more (as promised).
we should also just stop testing on XP. Maybe we should add testing on x64 instead, see bug 1308191.

Comment 9

[Jorg K (CEST = GMT+2)]

OK, you closed the bug, but the tree will remain perma-orange. Where is the bug to stop testing on XP? Until then, I don't think we can close this bug since we *do* have a problem.

Comment 10

[Masatoshi Kimura [:emk]]

(In reply to Jorg K (GMT+1) from comment #9)
> Where is the bug to stop testing on XP?

Bug 1319942?

Comment 11

[Jorg K (CEST = GMT+2)]

OK, thanks. Discussion will move to bug 1319942.

Comment 12

[aleth [:aleth]]

(In reply to Jorg K (GMT+1) from comment #9)
> OK, you closed the bug, but the tree will remain perma-orange. Where is the
> bug to stop testing on XP? Until then, I don't think we can close this bug
> since we *do* have a problem.

You could have read comment 5.

Comment 13

[Jorg K (CEST = GMT+2)]

I did read it at the time. Sorry, I didn't memorise it.