Closed
Bug 1319903
Opened 8 years ago
Closed 8 years ago
Ignore ParenExpr's when ignoring trivial expressions
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
|
3.20 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8813836 -
Flags: review?(michael)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ehsan
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8813836 [details] [diff] [review] Ignore ParenExpr's when ignoring trivial expressions Review of attachment 8813836 [details] [diff] [review]: ----------------------------------------------------------------- We might want to change the name of IgnoreImplicit to something like IgnoreTrivial to reflect the fact that it doesn't only remove implicit nodes, and also removes parens. Other than that, looks good to me!
Attachment #8813836 -
Flags: review?(michael) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Good idea, will do.
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e508878b3d8 Part 1: Ignore ParenExpr's when ignoring trivial expressions; r=mystor https://hg.mozilla.org/integration/mozilla-inbound/rev/96c3b7bcd5a7 Part 2: Rename IgnoreImplicit to IgnoreTrivials
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b19e41bbd08 Part 3: Revert to using Expr::IgnoreImplicit, pushed on a CLOSED TREE
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5e508878b3d8 https://hg.mozilla.org/mozilla-central/rev/96c3b7bcd5a7 https://hg.mozilla.org/mozilla-central/rev/9b19e41bbd08
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•