Closed Bug 1319903 Opened 3 years ago Closed 3 years ago

Ignore ParenExpr's when ignoring trivial expressions

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8813836 [details] [diff] [review]
Ignore ParenExpr's when ignoring trivial expressions

Review of attachment 8813836 [details] [diff] [review]:
-----------------------------------------------------------------

We might want to change the name of IgnoreImplicit to something like IgnoreTrivial to reflect the fact that it doesn't only remove implicit nodes, and also removes parens.

Other than that, looks good to me!
Attachment #8813836 - Flags: review?(michael) → review+
Good idea, will do.
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e508878b3d8
Part 1: Ignore ParenExpr's when ignoring trivial expressions; r=mystor
https://hg.mozilla.org/integration/mozilla-inbound/rev/96c3b7bcd5a7
Part 2: Rename IgnoreImplicit to IgnoreTrivials
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b19e41bbd08
Part 3: Revert to using Expr::IgnoreImplicit, pushed on a CLOSED TREE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.