1319910 - TestActorPunning and TestBadActor cxx IPDL unit tests fail

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

These two tests expect that when the parent detects an error it will kill the child, but that's been changed so that instead the parent just crashes. Part of this can be worked around by swapping around whether the unit test thinks the parent or child should die abruptly, but this still leaves the problem of the parent process crashing. Bill said this could be worked around by overriding FatalError to not be fatal.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1319910 - Crash child, not parent, on FatalError in TestActorPunning and TestBadActor.

The parent process crashes if it gets a bad message from the child,
but that makes it hard to test. This patch overrides the fatal error
handling method and uses the old behavior, that kills the child.

I copied the code to kill the child from TestHangs.

Review commit: https://reviewboard.mozilla.org/r/95192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95192/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813877 [details]
Bug 1319910 - Crash child, not parent, on FatalError in TestActorPunning and TestBadActor.

https://reviewboard.mozilla.org/r/95192/#review96210

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/739730a68de6
Crash child, not parent, on FatalError in TestActorPunning and TestBadActor. r=billm

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/739730a68de6