TestActorPunning and TestBadActor cxx IPDL unit tests fail

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

These two tests expect that when the parent detects an error it will kill the child, but that's been changed so that instead the parent just crashes. Part of this can be worked around by swapping around whether the unit test thinks the parent or child should die abruptly, but this still leaves the problem of the parent process crashing. Bill said this could be worked around by overriding FatalError to not be fatal.
Comment on attachment 8813877 [details]
Bug 1319910 - Crash child, not parent, on FatalError in TestActorPunning and TestBadActor.

https://reviewboard.mozilla.org/r/95192/#review96210
Attachment #8813877 - Flags: review?(wmccloskey) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/739730a68de6
Crash child, not parent, on FatalError in TestActorPunning and TestBadActor. r=billm
https://hg.mozilla.org/mozilla-central/rev/739730a68de6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.