Closed
Bug 1319934
Opened 8 years ago
Closed 8 years ago
Remove String generics uses in addon-sdk
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
1.47 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype. In addon-sdk/source/lib/sdk/tabs/utils.js, String.split needs to be replaced with a call to String.prototype.split. In addon-sdk/source/lib/sdk/url.js, String.indexOf needs to be replaced with a call to String.prototype.indexOf.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8814227 -
Flags: review?(dtownsend)
|
||
Updated•8 years ago
|
Attachment #8814227 -
Flags: review?(dtownsend) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9607364780c2 Remove String generics uses in addon-sdk. r=mossop
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9607364780c2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•