Closed Bug 1319935 Opened 3 years ago Closed 3 years ago

Remove String generics uses in devtools

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file)

The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype.


In devtools/client/webconsole/test/browser_webconsole_bug_1006027_message_timestamps_incorrect.js, String.trim needs to be replaced with a call to String.prototype.trim.
In devtools/shared/gcli/commands/addon.js, String.localeCompare needs to be replaced with a call to String.prototype.localeCompare.
Priority: -- → P3
Attached patch bug1319935.patchSplinter Review
Attachment #8814228 - Flags: review?(bgrinstead)
Attachment #8814228 - Flags: review?(bgrinstead) → review+
Thanks for reviewing!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8361e025e4c7
Remove String generics uses in devtools. r=bgrins
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8361e025e4c7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.