1319973 - Crash in mozilla::net::nsHttpConnection::OnSocketWritable

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Shian-Yow Wu [:swu]]

This bug was filed from the Socorro interface and is 
report bp-076a63af-5afa-40db-afe6-8a6512161123.
=============================================================

Information provided by NaN from irc:

my fx is crashing everytime and I suspect is because "Automatic proxy configuration", can someone please help me with this crash >> https://crash-stats.mozilla.com/report/index/bp-076a63af-5afa-40db-afe6-8a6512161123

Comment 1

[Shian-Yow Wu [:swu]]

It will be very helpful if someone can enable HTTP log, and provide the log when crash issue reproduced.
https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/HTTP_logging

Comment 2

[Patrick McManus [:mcmanus]]

timer calling connection after transaction has closed.

Comment 3

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e225251fd18

Comment 4

[Patrick McManus [:mcmanus]]

Attachment: tls proxy null in nshttpconnection::onsocketwritable after timer

Comment 5

[u408661]

Comment on attachment 8814940 [details] [diff] [review]
tls proxy null in  nshttpconnection::onsocketwritable after timer

Review of attachment 8814940 [details] [diff] [review]:
-----------------------------------------------------------------

Null checks gooooooooooood

Comment 6

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/334758dabe03d652b633736f71c8544c9c9d19cc
Bug 1319973 - tls proxy null in nshttpconnection::onsocketwritable after timer r=hurley

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/334758dabe03

Comment 8

[Marco Castelluccio [:marco]]

Are 51 and/or 52 affected? Should we uplift?

Comment 9

[Patrick McManus [:mcmanus]]

low volume null crash doesn't generally meet uplift criteria, though older versions are affected.

Comment 10

[Marco Castelluccio [:marco]]

It's a very simple patch, so I could see it being uplifted to Aurora.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Aurora approval.

Comment 12

[Patrick McManus [:mcmanus]]

Comment on attachment 8814940 [details] [diff] [review]
tls proxy null in  nshttpconnection::onsocketwritable after timer

Approval Request Comment
[Feature/Bug causing the regression]: http/2 proxying (very old)
[User impact if declined]: potential null crash
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple null check
[String changes made/needed]: none

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8814940 [details] [diff] [review]
tls proxy null in  nshttpconnection::onsocketwritable after timer

fix potential crash with http/2 proxying, beta52+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa38e34faf4a